platform/testing/{URL|Unit}TestHelpers improvements

third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 50 matching lines @@
 #include "public/web/WebSettings.h"
 #include "public/web/WebView.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/skia/include/core/SkPictureRecorder.h"
 #include "web/WebLocalFrameImpl.h"
 #include "web/WebPluginContainerImpl.h"
 #include "web/WebViewImpl.h"
 #include "web/tests/FakeWebPlugin.h"
 #include "web/tests/FrameTestHelpers.h"
 #include <memory>
+#include <string>
 
 using blink::testing::runPendingTasks;
 
 namespace blink {
 
 class WebPluginContainerTest : public ::testing::Test {
  public:
   WebPluginContainerTest() : m_baseURL("http://www.test.com/") {}
 
   void TearDown() override {
     Platform::current()->getURLLoaderMockFactory()->unregisterAllURLs();
     WebCache::clear();
   }
 
   void calculateGeometry(WebPluginContainerImpl* pluginContainerImpl,
                          IntRect& windowRect,
                          IntRect& clipRect,
                          IntRect& unobscuredRect,
                          Vector<IntRect>& cutOutRects) {
     pluginContainerImpl->calculateGeometry(windowRect, clipRect, unobscuredRect,
                                            cutOutRects);
   }
 
+  void registerMockedURL(
+      const std::string& fileName,
+      const std::string& mimeType = std::string("text/html")) {
+    URLTestHelpers::registerMockedURLLoadFromBase(
+        WebString::fromUTF8(m_baseURL.c_str()), testing::webTestDataPath(),

[kinuko, 2017/01/26 09:32:41]

ditto

[Takashi Toyoshima, 2017/01/26 10:57:58]

Done.

+        WebString::fromUTF8(fileName), WebString::fromUTF8(mimeType.c_str()));
+  }
+
  protected:
   std::string m_baseURL;
 };
 
 namespace {
 
 template <typename T>
 class CustomPluginWebFrameClient : public FrameTestHelpers::TestWebFrameClient {
  public:
   WebPlugin* createPlugin(WebLocalFrame* frame,
@@ skipping 50 matching lines @@
 
 WebPluginContainer* getWebPluginContainer(WebView* webView,
                                           const WebString& id) {
   WebElement element = webView->mainFrame()->document().getElementById(id);
   return element.pluginContainer();
 }
 
 }  // namespace
 
 TEST_F(WebPluginContainerTest, WindowToLocalPointTest) {
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(m_baseURL.c_str()),
-      WebString::fromUTF8("plugin_container.html"));
+  registerMockedURL("plugin_container.html");
   TestPluginWebFrameClient pluginWebFrameClient;  // Must outlive webViewHelper.
   FrameTestHelpers::WebViewHelper webViewHelper;
   WebView* webView = webViewHelper.initializeAndLoad(
       m_baseURL + "plugin_container.html", true, &pluginWebFrameClient);
   DCHECK(webView);
   webView->settings()->setPluginsEnabled(true);
   webView->resize(WebSize(300, 300));
   webView->updateAllLifecyclePhases();
   runPendingTasks();
 
@@ skipping 14 matching lines @@
   WebPoint point3 = pluginContainerTwo->rootFrameToLocalPoint(WebPoint(0, 10));
   ASSERT_EQ(10, point3.x);
   ASSERT_EQ(0, point3.y);
   WebPoint point4 =
       pluginContainerTwo->rootFrameToLocalPoint(WebPoint(-10, 10));
   ASSERT_EQ(10, point4.x);
   ASSERT_EQ(10, point4.y);
 }
 
 TEST_F(WebPluginContainerTest, PluginDocumentPluginIsFocused) {
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("test.pdf"),
-      WebString::fromUTF8("application/pdf"));
+  registerMockedURL("test.pdf", "application/pdf");
 
   TestPluginWebFrameClient pluginWebFrameClient;  // Must outlive webViewHelper.
   FrameTestHelpers::WebViewHelper webViewHelper;
   WebView* webView = webViewHelper.initializeAndLoad(
       m_baseURL + "test.pdf", true, &pluginWebFrameClient);
   DCHECK(webView);
   webView->updateAllLifecyclePhases();
 
   WebDocument document = webView->mainFrame()->document();
   EXPECT_TRUE(document.isPluginDocument());
   WebPluginContainer* pluginContainer =
       getWebPluginContainer(webView, "plugin");
   EXPECT_EQ(document.focusedElement(), pluginContainer->element());
 }
 
 TEST_F(WebPluginContainerTest, IFramePluginDocumentNotFocused) {
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("test.pdf"),
-      WebString::fromUTF8("application/pdf"));
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(m_baseURL.c_str()),
-      WebString::fromUTF8("iframe_pdf.html"), WebString::fromUTF8("text/html"));
+  registerMockedURL("test.pdf", "application/pdf");
+  registerMockedURL("iframe_pdf.html", "text/html");
 
   TestPluginWebFrameClient pluginWebFrameClient;  // Must outlive webViewHelper.
   FrameTestHelpers::WebViewHelper webViewHelper;
   WebView* webView = webViewHelper.initializeAndLoad(
       m_baseURL + "iframe_pdf.html", true, &pluginWebFrameClient);
   DCHECK(webView);
   webView->updateAllLifecyclePhases();
 
   WebDocument document = webView->mainFrame()->document();
   WebFrame* iframe = webView->mainFrame()->firstChild();
   EXPECT_TRUE(iframe->document().isPluginDocument());
   WebPluginContainer* pluginContainer =
       iframe->document().getElementById("plugin").pluginContainer();
   EXPECT_NE(document.focusedElement(), pluginContainer->element());
   EXPECT_NE(iframe->document().focusedElement(), pluginContainer->element());
 }
 
 TEST_F(WebPluginContainerTest, PrintOnePage) {
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("test.pdf"),
-      WebString::fromUTF8("application/pdf"));
+  registerMockedURL("test.pdf", "application/pdf");
 
   TestPluginWebFrameClient pluginWebFrameClient;  // Must outlive webViewHelper.
   FrameTestHelpers::WebViewHelper webViewHelper;
   WebView* webView = webViewHelper.initializeAndLoad(
       m_baseURL + "test.pdf", true, &pluginWebFrameClient);
   DCHECK(webView);
   webView->updateAllLifecyclePhases();
   runPendingTasks();
   WebFrame* frame = webView->mainFrame();
 
   WebPrintParams printParams;
   printParams.printContentArea.width = 500;
   printParams.printContentArea.height = 500;
 
   frame->printBegin(printParams);
   SkPictureRecorder recorder;
   frame->printPage(0, recorder.beginRecording(IntRect()));
   frame->printEnd();
   DCHECK(pluginWebFrameClient.printedAtLeastOnePage());
 }
 
 TEST_F(WebPluginContainerTest, PrintAllPages) {
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("test.pdf"),
-      WebString::fromUTF8("application/pdf"));
+  registerMockedURL("test.pdf", "application/pdf");
 
   TestPluginWebFrameClient pluginWebFrameClient;  // Must outlive webViewHelper.
   FrameTestHelpers::WebViewHelper webViewHelper;
   WebView* webView = webViewHelper.initializeAndLoad(
       m_baseURL + "test.pdf", true, &pluginWebFrameClient);
   DCHECK(webView);
   webView->updateAllLifecyclePhases();
   runPendingTasks();
   WebFrame* frame = webView->mainFrame();
 
   WebPrintParams printParams;
   printParams.printContentArea.width = 500;
   printParams.printContentArea.height = 500;
 
   frame->printBegin(printParams);
   SkPictureRecorder recorder;
   frame->printPagesWithBoundaries(recorder.beginRecording(IntRect()),
                                   WebSize());
   frame->printEnd();
   DCHECK(pluginWebFrameClient.printedAtLeastOnePage());
 }
 
 TEST_F(WebPluginContainerTest, LocalToWindowPointTest) {
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(m_baseURL.c_str()),
-      WebString::fromUTF8("plugin_container.html"));
+  registerMockedURL("plugin_container.html");
   TestPluginWebFrameClient pluginWebFrameClient;  // Must outlive webViewHelper.
   FrameTestHelpers::WebViewHelper webViewHelper;
   WebView* webView = webViewHelper.initializeAndLoad(
       m_baseURL + "plugin_container.html", true, &pluginWebFrameClient);
   DCHECK(webView);
   webView->settings()->setPluginsEnabled(true);
   webView->resize(WebSize(300, 300));
   webView->updateAllLifecyclePhases();
   runPendingTasks();
 
@@ skipping 13 matching lines @@
   WebPoint point3 = pluginContainerTwo->localToRootFramePoint(WebPoint(10, 0));
   ASSERT_EQ(0, point3.x);
   ASSERT_EQ(10, point3.y);
   WebPoint point4 = pluginContainerTwo->localToRootFramePoint(WebPoint(10, 10));
   ASSERT_EQ(-10, point4.x);
   ASSERT_EQ(10, point4.y);
 }
 
 // Verifies executing the command 'Copy' results in copying to the clipboard.
 TEST_F(WebPluginContainerTest, Copy) {
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(m_baseURL.c_str()),
-      WebString::fromUTF8("plugin_container.html"));
+  registerMockedURL("plugin_container.html");
   TestPluginWebFrameClient pluginWebFrameClient;  // Must outlive webViewHelper.
   FrameTestHelpers::WebViewHelper webViewHelper;
   WebView* webView = webViewHelper.initializeAndLoad(
       m_baseURL + "plugin_container.html", true, &pluginWebFrameClient);
   DCHECK(webView);
   webView->settings()->setPluginsEnabled(true);
   webView->resize(WebSize(300, 300));
   webView->updateAllLifecyclePhases();
   runPendingTasks();
 
   webView->mainFrame()
       ->document()
       .unwrap<Document>()
       ->body()
       ->getElementById("translated-plugin")
       ->focus();
   EXPECT_TRUE(webView->mainFrame()->toWebLocalFrame()->executeCommand("Copy"));
   EXPECT_EQ(WebString("x"), Platform::current()->clipboard()->readPlainText(
                                 WebClipboard::Buffer()));
 }
 
 TEST_F(WebPluginContainerTest, CopyFromContextMenu) {
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(m_baseURL.c_str()),
-      WebString::fromUTF8("plugin_container.html"));
+  registerMockedURL("plugin_container.html");
   TestPluginWebFrameClient pluginWebFrameClient;  // Must outlive webViewHelper.
   FrameTestHelpers::WebViewHelper webViewHelper;
   WebView* webView = webViewHelper.initializeAndLoad(
       m_baseURL + "plugin_container.html", true, &pluginWebFrameClient);
   DCHECK(webView);
   webView->settings()->setPluginsEnabled(true);
   webView->resize(WebSize(300, 300));
   webView->updateAllLifecyclePhases();
   runPendingTasks();
 
@@ skipping 21 matching lines @@
   // 3) Copy should still operate on the context node, even though the focus had
   //    shifted.
   EXPECT_TRUE(webView->mainFrame()->toWebLocalFrame()->executeCommand("Copy"));
   EXPECT_EQ(WebString("x"), Platform::current()->clipboard()->readPlainText(
                                 WebClipboard::Buffer()));
 }
 
 // Verifies |Ctrl-C| and |Ctrl-Insert| keyboard events, results in copying to
 // the clipboard.
 TEST_F(WebPluginContainerTest, CopyInsertKeyboardEventsTest) {
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(m_baseURL.c_str()),
-      WebString::fromUTF8("plugin_container.html"));
+  registerMockedURL("plugin_container.html");
   TestPluginWebFrameClient pluginWebFrameClient;  // Must outlive webViewHelper.
   FrameTestHelpers::WebViewHelper webViewHelper;
   WebView* webView = webViewHelper.initializeAndLoad(
       m_baseURL + "plugin_container.html", true, &pluginWebFrameClient);
   DCHECK(webView);
   webView->settings()->setPluginsEnabled(true);
   webView->resize(WebSize(300, 300));
   webView->updateAllLifecyclePhases();
   runPendingTasks();
 
@@ skipping 56 matching lines @@
   WebInputEvent::Type getLastInputEventType() { return m_lastEventType; }
 
   IntPoint getLastMouseEventLocation() { return m_lastMouseEventLocation; }
 
  private:
   WebInputEvent::Type m_lastEventType;
   IntPoint m_lastMouseEventLocation;
 };
 
 TEST_F(WebPluginContainerTest, GestureLongPressReachesPlugin) {
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(m_baseURL.c_str()),
-      WebString::fromUTF8("plugin_container.html"));
+  registerMockedURL("plugin_container.html");
   CustomPluginWebFrameClient<EventTestPlugin>
       pluginWebFrameClient;  // Must outlive webViewHelper.
   FrameTestHelpers::WebViewHelper webViewHelper;
   WebView* webView = webViewHelper.initializeAndLoad(
       m_baseURL + "plugin_container.html", true, &pluginWebFrameClient);
   DCHECK(webView);
   webView->settings()->setPluginsEnabled(true);
   webView->resize(WebSize(300, 300));
   webView->updateAllLifecyclePhases();
   runPendingTasks();
@@ skipping 28 matching lines @@
   event.y = rect.y + rect.height / 2;
 
   webView->handleInputEvent(WebCoalescedInputEvent(event));
   runPendingTasks();
 
   EXPECT_EQ(WebInputEvent::GestureLongPress,
             testPlugin->getLastInputEventType());
 }
 
 TEST_F(WebPluginContainerTest, MouseWheelEventTranslated) {
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(m_baseURL.c_str()),
-      WebString::fromUTF8("plugin_container.html"));
+  registerMockedURL("plugin_container.html");
   CustomPluginWebFrameClient<EventTestPlugin>
       pluginWebFrameClient;  // Must outlive webViewHelper.
   FrameTestHelpers::WebViewHelper webViewHelper;
   WebView* webView = webViewHelper.initializeAndLoad(
       m_baseURL + "plugin_container.html", true, &pluginWebFrameClient);
   DCHECK(webView);
   webView->settings()->setPluginsEnabled(true);
   webView->resize(WebSize(300, 300));
   webView->updateAllLifecyclePhases();
   runPendingTasks();
@@ skipping 17 matching lines @@
   webView->handleInputEvent(WebCoalescedInputEvent(event));
   runPendingTasks();
 
   EXPECT_EQ(WebInputEvent::MouseWheel, testPlugin->getLastInputEventType());
   EXPECT_EQ(rect.width / 2, testPlugin->getLastMouseEventLocation().x());
   EXPECT_EQ(rect.height / 2, testPlugin->getLastMouseEventLocation().y());
 }
 
 // Verify that isRectTopmost returns false when the document is detached.
 TEST_F(WebPluginContainerTest, IsRectTopmostTest) {
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(m_baseURL.c_str()),
-      WebString::fromUTF8("plugin_container.html"));
+  registerMockedURL("plugin_container.html");
   TestPluginWebFrameClient pluginWebFrameClient;  // Must outlive webViewHelper.
   FrameTestHelpers::WebViewHelper webViewHelper;
   WebView* webView = webViewHelper.initializeAndLoad(
       m_baseURL + "plugin_container.html", true, &pluginWebFrameClient);
   DCHECK(webView);
   webView->settings()->setPluginsEnabled(true);
   webView->resize(WebSize(300, 300));
   webView->updateAllLifecyclePhases();
   runPendingTasks();
 
@@ skipping 13 matching lines @@
 #define EXPECT_RECT_EQ(expected, actual)               \
   do {                                                 \
     const IntRect& actualRect = actual;                \
     EXPECT_EQ(expected.x(), actualRect.x());           \
     EXPECT_EQ(expected.y(), actualRect.y());           \
     EXPECT_EQ(expected.width(), actualRect.width());   \
     EXPECT_EQ(expected.height(), actualRect.height()); \
   } while (false)
 
 TEST_F(WebPluginContainerTest, ClippedRectsForIframedElement) {
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(m_baseURL.c_str()),
-      WebString::fromUTF8("plugin_container.html"));
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(m_baseURL.c_str()),
-      WebString::fromUTF8("plugin_containing_page.html"));
+  registerMockedURL("plugin_container.html");
+  registerMockedURL("plugin_containing_page.html");
 
   TestPluginWebFrameClient pluginWebFrameClient;  // Must outlive webViewHelper.
   FrameTestHelpers::WebViewHelper webViewHelper;
   WebView* webView = webViewHelper.initializeAndLoad(
       m_baseURL + "plugin_containing_page.html", true, &pluginWebFrameClient);
   DCHECK(webView);
   webView->settings()->setPluginsEnabled(true);
   webView->resize(WebSize(300, 300));
   webView->updateAllLifecyclePhases();
   runPendingTasks();
@@ skipping 12 matching lines @@
                     cutOutRects);
   EXPECT_RECT_EQ(IntRect(20, 220, 40, 40), windowRect);
   EXPECT_RECT_EQ(IntRect(0, 0, 40, 40), clipRect);
   EXPECT_RECT_EQ(IntRect(0, 0, 40, 40), unobscuredRect);
 
   // Cause the plugin's frame to be detached.
   webViewHelper.reset();
 }
 
 TEST_F(WebPluginContainerTest, ClippedRectsForSubpixelPositionedPlugin) {
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(m_baseURL.c_str()),
-      WebString::fromUTF8("plugin_container.html"));
+  registerMockedURL("plugin_container.html");
 
   TestPluginWebFrameClient pluginWebFrameClient;  // Must outlive webViewHelper.
   FrameTestHelpers::WebViewHelper webViewHelper;
   WebView* webView = webViewHelper.initializeAndLoad(
       m_baseURL + "plugin_container.html", true, &pluginWebFrameClient);
   DCHECK(webView);
   webView->settings()->setPluginsEnabled(true);
   webView->resize(WebSize(300, 300));
   webView->updateAllLifecyclePhases();
   runPendingTasks();
@@ skipping 29 matching lines @@
 
     bool isRectTopmost() { return container()->isRectTopmost(topmostRect); }
 
     void destroy() override {
       // In destroy, isRectTopmost is no longer valid.
       EXPECT_FALSE(container()->isRectTopmost(topmostRect));
       FakeWebPlugin::destroy();
     }
   };
 
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(m_baseURL.c_str()),
-      WebString::fromUTF8("plugin_container.html"));
+  registerMockedURL("plugin_container.html");
   CustomPluginWebFrameClient<TopmostPlugin>
       pluginWebFrameClient;  // Must outlive webViewHelper.
   FrameTestHelpers::WebViewHelper webViewHelper;
   WebView* webView = webViewHelper.initializeAndLoad(
       m_baseURL + "plugin_container.html", true, &pluginWebFrameClient);
   DCHECK(webView);
   webView->settings()->setPluginsEnabled(true);
   webView->resize(WebSize(300, 300));
   webView->updateAllLifecyclePhases();
   runPendingTasks();
@@ skipping 39 matching lines @@
   }
 
  private:
   std::unique_ptr<WebLayer> m_layer;
 };
 
 }  // namespace
 
 TEST_F(WebPluginContainerTest, CompositedPluginSPv2) {
   ScopedSlimmingPaintV2ForTest enableSPv2(true);
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(m_baseURL.c_str()),
-      WebString::fromUTF8("plugin.html"));
+  registerMockedURL("plugin.html");
   CustomPluginWebFrameClient<CompositedPlugin> webFrameClient;
   FrameTestHelpers::WebViewHelper webViewHelper;
   WebView* webView = webViewHelper.initializeAndLoad(m_baseURL + "plugin.html",
                                                      true, &webFrameClient);
   ASSERT_TRUE(webView);
   webView->settings()->setPluginsEnabled(true);
   webView->resize(WebSize(800, 600));
   webView->updateAllLifecyclePhases();
   runPendingTasks();
 
@@ skipping 19 matching lines @@
       paintController->paintArtifact().getDisplayItemList();
   ASSERT_EQ(1u, displayItems.size());
   EXPECT_EQ(element->layoutObject(), &displayItems[0].client());
   ASSERT_EQ(DisplayItem::kForeignLayerPlugin, displayItems[0].getType());
   const auto& foreignLayerDisplayItem =
       static_cast<const ForeignLayerDisplayItem&>(displayItems[0]);
   EXPECT_EQ(plugin->getWebLayer()->ccLayer(), foreignLayerDisplayItem.layer());
 }
 
 TEST_F(WebPluginContainerTest, NeedsWheelEvents) {
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(m_baseURL.c_str()),
-      WebString::fromUTF8("plugin_container.html"));
+  registerMockedURL("plugin_container.html");
   TestPluginWebFrameClient pluginWebFrameClient;  // Must outlive webViewHelper
   FrameTestHelpers::WebViewHelper webViewHelper;
   WebViewImpl* webView = webViewHelper.initializeAndLoad(
       m_baseURL + "plugin_container.html", true, &pluginWebFrameClient);
   DCHECK(webView);
   webView->settings()->setPluginsEnabled(true);
   webView->resize(WebSize(300, 300));
   webView->updateAllLifecyclePhases();
   runPendingTasks();
 
   WebElement pluginContainerOneElement =
       webView->mainFrame()->document().getElementById(
           WebString::fromUTF8("translated-plugin"));
   pluginContainerOneElement.pluginContainer()->setWantsWheelEvents(true);
 
   runPendingTasks();
   EXPECT_TRUE(
       webView->page()->frameHost().eventHandlerRegistry().hasEventHandlers(
           EventHandlerRegistry::WheelEventBlocking));
 }
 
 }  // namespace blink