platform/testing/{URL|Unit}TestHelpers improvements

third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 27 matching lines @@
 #include "core/events/TouchEvent.h"
 #include "core/events/WheelEvent.h"
 #include "core/frame/FrameHost.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/VisualViewport.h"
 #include "core/layout/api/LayoutViewItem.h"
 #include "core/page/Page.h"
 #include "platform/geometry/IntSize.h"
 #include "platform/testing/URLTestHelpers.h"
+#include "platform/testing/UnitTestHelpers.h"
 #include "public/web/WebFrame.h"
 #include "public/web/WebSettings.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "web/WebLocalFrameImpl.h"
 #include "web/WebViewImpl.h"
 #include "web/tests/FrameTestHelpers.h"
 
 namespace blink {
 
+namespace {
+
 KeyboardEvent* createKeyboardEventWithLocation(
     KeyboardEvent::KeyLocationCode location) {
   KeyboardEventInit keyEventInit;
   keyEventInit.setBubbles(true);
   keyEventInit.setCancelable(true);
   keyEventInit.setLocation(location);
   return new KeyboardEvent("keydown", keyEventInit);
 }
 
 int getModifiersForKeyLocationCode(KeyboardEvent::KeyLocationCode location) {
   KeyboardEvent* event = createKeyboardEventWithLocation(location);
   WebKeyboardEventBuilder convertedEvent(*event);
   return convertedEvent.modifiers();
 }
 
+void registerMockedURL(const std::string& baseURL,
+                       const std::string& fileName) {
+  URLTestHelpers::registerMockedURLLoadFromBase(
+      WebString::fromUTF8(baseURL.c_str()), testing::webTestDataPath(),

[kinuko, 2017/01/26 09:32:41]

ditto

[Takashi Toyoshima, 2017/01/26 10:57:58]

Done.

+      WebString::fromUTF8(fileName));
+}
+
+}  // namespace
+
 TEST(WebInputEventConversionTest, WebKeyboardEventBuilder) {
   // Test key location conversion.
   int modifiers =
       getModifiersForKeyLocationCode(KeyboardEvent::kDomKeyLocationStandard);
   EXPECT_FALSE(modifiers & WebInputEvent::IsKeyPad ||
                modifiers & WebInputEvent::IsLeft ||
                modifiers & WebInputEvent::IsRight);
 
   modifiers =
       getModifiersForKeyLocationCode(KeyboardEvent::kDomKeyLocationLeft);
@@ skipping 17 matching lines @@
 TEST(WebInputEventConversionTest, WebMouseEventBuilder) {
   TouchEvent* event = TouchEvent::create();
   WebMouseEventBuilder mouse(0, 0, *event);
   EXPECT_EQ(WebInputEvent::Undefined, mouse.type());
 }
 
 TEST(WebInputEventConversionTest, WebTouchEventBuilder) {
   const std::string baseURL("http://www.test0.com/");
   const std::string fileName("fixed_layout.html");
 
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(baseURL.c_str()),
-      WebString::fromUTF8("fixed_layout.html"));
+  registerMockedURL(baseURL, fileName);
   FrameTestHelpers::WebViewHelper webViewHelper;
   WebViewImpl* webViewImpl =
       webViewHelper.initializeAndLoad(baseURL + fileName, true);
   int pageWidth = 640;
   int pageHeight = 480;
   webViewImpl->resize(WebSize(pageWidth, pageHeight));
   webViewImpl->updateAllLifecyclePhases();
 
   Document* document =
       toLocalFrame(webViewImpl->page()->mainFrame())->document();
@@ skipping 173 matching lines @@
     WebTouchEventBuilder webTouchBuilder(documentLayoutView, *touchEvent);
     ASSERT_EQ(static_cast<unsigned>(WebTouchEvent::kTouchesLengthCap),
               webTouchBuilder.touchesLength);
   }
 }
 
 TEST(WebInputEventConversionTest, InputEventsScaling) {
   const std::string baseURL("http://www.test1.com/");
   const std::string fileName("fixed_layout.html");
 
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(baseURL.c_str()),
-      WebString::fromUTF8("fixed_layout.html"));
+  registerMockedURL(baseURL, fileName);
   FrameTestHelpers::WebViewHelper webViewHelper;
   WebViewImpl* webViewImpl =
       webViewHelper.initializeAndLoad(baseURL + fileName, true);
   webViewImpl->settings()->setViewportEnabled(true);
   int pageWidth = 640;
   int pageHeight = 480;
   webViewImpl->resize(WebSize(pageWidth, pageHeight));
   webViewImpl->updateAllLifecyclePhases();
 
   webViewImpl->setPageScaleFactor(2);
@@ skipping 259 matching lines @@
     EXPECT_FLOAT_EQ(4, webTouchBuilder.touches[0].radiusX);
     EXPECT_FLOAT_EQ(4.5, webTouchBuilder.touches[0].radiusY);
     EXPECT_EQ(WebInputEvent::EventNonBlocking, webTouchBuilder.dispatchType);
   }
 }
 
 TEST(WebInputEventConversionTest, InputEventsTransform) {
   const std::string baseURL("http://www.test2.com/");
   const std::string fileName("fixed_layout.html");
 
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(baseURL.c_str()),
-      WebString::fromUTF8("fixed_layout.html"));
+  registerMockedURL(baseURL, fileName);
   FrameTestHelpers::WebViewHelper webViewHelper;
   WebViewImpl* webViewImpl =
       webViewHelper.initializeAndLoad(baseURL + fileName, true);
   webViewImpl->settings()->setViewportEnabled(true);
   int pageWidth = 640;
   int pageHeight = 480;
   webViewImpl->resize(WebSize(pageWidth, pageHeight));
   webViewImpl->updateAllLifecyclePhases();
 
   webViewImpl->setPageScaleFactor(2);
@@ skipping 242 matching lines @@
     EXPECT_FLOAT_EQ(30, coalescedevents[1].touchPoints()[0].pos().y());
     EXPECT_FLOAT_EQ(20, coalescedevents[1].touchPoints()[0].radius().width());
     EXPECT_FLOAT_EQ(10, coalescedevents[1].touchPoints()[0].radius().height());
   }
 }
 
 TEST(WebInputEventConversionTest, InputEventsConversions) {
   const std::string baseURL("http://www.test3.com/");
   const std::string fileName("fixed_layout.html");
 
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(baseURL.c_str()),
-      WebString::fromUTF8("fixed_layout.html"));
+  registerMockedURL(baseURL, fileName);
   FrameTestHelpers::WebViewHelper webViewHelper;
   WebViewImpl* webViewImpl =
       webViewHelper.initializeAndLoad(baseURL + fileName, true);
   int pageWidth = 640;
   int pageHeight = 480;
   webViewImpl->resize(WebSize(pageWidth, pageHeight));
   webViewImpl->updateAllLifecyclePhases();
 
   FrameView* view = toLocalFrame(webViewImpl->page()->mainFrame())->view();
   {
@@ skipping 18 matching lines @@
     EXPECT_EQ(10.f, scaledGestureEvent.globalX);
     EXPECT_EQ(10.f, scaledGestureEvent.globalY);
     EXPECT_EQ(1, scaledGestureEvent.tapCount());
   }
 }
 
 TEST(WebInputEventConversionTest, VisualViewportOffset) {
   const std::string baseURL("http://www.test4.com/");
   const std::string fileName("fixed_layout.html");
 
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(baseURL.c_str()),
-      WebString::fromUTF8("fixed_layout.html"));
+  registerMockedURL(baseURL, fileName);
   FrameTestHelpers::WebViewHelper webViewHelper;
   WebViewImpl* webViewImpl =
       webViewHelper.initializeAndLoad(baseURL + fileName, true);
   int pageWidth = 640;
   int pageHeight = 480;
   webViewImpl->resize(WebSize(pageWidth, pageHeight));
   webViewImpl->updateAllLifecyclePhases();
 
   webViewImpl->setPageScaleFactor(2);
 
@@ skipping 86 matching lines @@
                     platformTouchBuilder.touchPoints()[0].pos().x());
     EXPECT_FLOAT_EQ(5.2f + visualOffset.y(),
                     platformTouchBuilder.touchPoints()[0].pos().y());
   }
 }
 
 TEST(WebInputEventConversionTest, ElasticOverscroll) {
   const std::string baseURL("http://www.test5.com/");
   const std::string fileName("fixed_layout.html");
 
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(baseURL.c_str()),
-      WebString::fromUTF8("fixed_layout.html"));
+  registerMockedURL(baseURL, fileName);
   FrameTestHelpers::WebViewHelper webViewHelper;
   WebViewImpl* webViewImpl =
       webViewHelper.initializeAndLoad(baseURL + fileName, true);
   int pageWidth = 640;
   int pageHeight = 480;
   webViewImpl->resize(WebSize(pageWidth, pageHeight));
   webViewImpl->updateAllLifecyclePhases();
 
   FrameView* view = toLocalFrame(webViewImpl->page()->mainFrame())->view();
 
@@ skipping 50 matching lines @@
     EXPECT_EQ(webMouseEvent.globalX, platformMouseBuilder.globalPosition().x());
     EXPECT_EQ(webMouseEvent.globalY, platformMouseBuilder.globalPosition().y());
   }
 }
 
 // Page reload/navigation should not reset elastic overscroll.
 TEST(WebInputEventConversionTest, ElasticOverscrollWithPageReload) {
   const std::string baseURL("http://www.test6.com/");
   const std::string fileName("fixed_layout.html");
 
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(baseURL.c_str()),
-      WebString::fromUTF8("fixed_layout.html"));
+  registerMockedURL(baseURL, fileName);
   FrameTestHelpers::WebViewHelper webViewHelper;
   WebViewImpl* webViewImpl =
       webViewHelper.initializeAndLoad(baseURL + fileName, true);
   int pageWidth = 640;
   int pageHeight = 480;
   webViewImpl->resize(WebSize(pageWidth, pageHeight));
   webViewImpl->updateAllLifecyclePhases();
 
   FloatSize elasticOverscroll(10, -20);
   webViewImpl->applyViewportDeltas(WebFloatSize(), WebFloatSize(),
@@ skipping 17 matching lines @@
     EXPECT_EQ(webMouseEvent.x + elasticOverscroll.width(),
               platformMouseBuilder.position().x());
     EXPECT_EQ(webMouseEvent.y + elasticOverscroll.height(),
               platformMouseBuilder.position().y());
     EXPECT_EQ(webMouseEvent.globalX, platformMouseBuilder.globalPosition().x());
     EXPECT_EQ(webMouseEvent.globalY, platformMouseBuilder.globalPosition().y());
   }
 }
 
 }  // namespace blink