platform/testing/{URL|Unit}TestHelpers improvements

third_party/WebKit/Source/web/tests/WebFrameSerializerTest.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "public/web/WebFrameSerializer.h"
 
 #include "platform/testing/URLTestHelpers.h"
+#include "platform/testing/UnitTestHelpers.h"
 #include "platform/weborigin/KURL.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebCString.h"
 #include "public/platform/WebString.h"
 #include "public/platform/WebURL.h"
 #include "public/platform/WebURLLoaderMockFactory.h"
 #include "public/web/WebCache.h"
 #include "public/web/WebFrameSerializerClient.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "web/WebLocalFrameImpl.h"
@@ skipping 50 matching lines @@
     if (pos == WTF::kNotFound)
       break;
     matches++;
     start = pos + size;
   }
   return matches;
 }
 
 }  // namespace
 
-class WebFrameSerializerTest : public testing::Test {
+class WebFrameSerializerTest : public ::testing::Test {
  protected:
   WebFrameSerializerTest() { m_helper.initialize(); }
 
   ~WebFrameSerializerTest() override {
     Platform::current()->getURLLoaderMockFactory()->unregisterAllURLs();
     WebCache::clear();
   }
 
-  void registerMockedImageURL(const String& url) {
+  void registerMockedImageURLLoad(const String& url) {
     // Image resources need to be mocked, but irrelevant here what image they
     // map to.
-    URLTestHelpers::registerMockedURLLoad(KURL(ParsedURLString, url),
-                                          "frameserialization/awesome.png");
+    registerMockedFileURLLoad(URLTestHelpers::toKURL(url.utf8().data()),
+                              "frameserialization/awesome.png");
+  }
+  void registerMockedFileURLLoad(const KURL& url,
+                                 const String& filePath,
+                                 const String& mimeType = "image/png") {
+    URLTestHelpers::registerMockedURLLoad(
+        url, testing::webTestDataPath(filePath.utf8().data()), mimeType);
   }
 
   class SingleLinkRewritingDelegate
       : public WebFrameSerializer::LinkRewritingDelegate {
    public:
     SingleLinkRewritingDelegate(const WebURL& url, const WebString& localPath)
         : m_url(url), m_localPath(localPath) {}
 
     bool rewriteFrameSource(WebFrame* frame,
                             WebString* rewrittenLink) override {
       return false;
     }
 
     bool rewriteLink(const WebURL& url, WebString* rewrittenLink) override {
       if (url != m_url)
         return false;
 
       *rewrittenLink = m_localPath;
       return true;
     }
 
    private:
     const WebURL m_url;
     const WebString m_localPath;
   };
 
   String serializeFile(const String& url, const String& fileName) {
     KURL parsedURL(ParsedURLString, url);
-    URLTestHelpers::registerMockedURLLoad(parsedURL, fileName,
-                                          "frameserialization/", "text/html");
+    String filePath("frameserialization/" + fileName);
+    registerMockedFileURLLoad(parsedURL, filePath, "text/html");
     FrameTestHelpers::loadFrame(mainFrameImpl(), url.utf8().data());
     SingleLinkRewritingDelegate delegate(parsedURL, WebString("local"));
     SimpleWebFrameSerializerClient serializerClient;
     WebFrameSerializer::serialize(mainFrameImpl(), &serializerClient,
                                   &delegate);
     return serializerClient.toString();
   }
 
   WebViewImpl* webView() { return m_helper.webView(); }
 
   WebLocalFrameImpl* mainFrameImpl() {
     return m_helper.webView()->mainFrameImpl();
   }
 
  private:
   FrameTestHelpers::WebViewHelper m_helper;
 };
 
 TEST_F(WebFrameSerializerTest, URLAttributeValues) {
-  registerMockedImageURL("javascript:\"");
+  registerMockedImageURLLoad("javascript:\"");
 
   const char* expectedHTML =
       "\n<!-- saved from url=(0020)http://www.test.com/ -->\n"
       "<html><head><meta http-equiv=\"Content-Type\" content=\"text/html; "
       "charset=UTF-8\">\n"
       "</head><body><img src=\"javascript:&quot;\">\n"
       "<a href=\"http://www.test.com/local#&quot;\">local</a>\n"
       "<a "
       "href=\"http://www.example.com/#&quot;&gt;&lt;script&gt;alert(0)&lt;/"
       "script&gt;\">external</a>\n"
@@ skipping 29 matching lines @@
 class WebFrameSerializerSanitizationTest : public WebFrameSerializerTest {
  protected:
   WebFrameSerializerSanitizationTest() {}
 
   ~WebFrameSerializerSanitizationTest() override {}
 
   String generateMHTMLParts(const String& url,
                             const String& fileName,
                             const String& mimeType = "text/html") {
     KURL parsedURL(ParsedURLString, url);
-    URLTestHelpers::registerMockedURLLoad(parsedURL, fileName,
-                                          "frameserialization/", mimeType);
+    String filePath("frameserialization/" + fileName);
+    registerMockedFileURLLoad(parsedURL, filePath, mimeType);
     FrameTestHelpers::loadFrame(mainFrameImpl(), url.utf8().data());
     WebThreadSafeData result = WebFrameSerializer::generateMHTMLParts(
         WebString("boundary"), mainFrameImpl(), &m_mhtmlDelegate);
     return String(result.data(), result.size());
   }
 
   void setRemovePopupOverlay(bool removePopupOverlay) {
     m_mhtmlDelegate.setRemovePopupOverlay(removePopupOverlay);
   }
 
@@ skipping 67 matching lines @@
 
 // Regression test for crbug.com/678893, where in some cases serializing an
 // image document could cause code to pick an element from an empty container.
 TEST_F(WebFrameSerializerSanitizationTest, FromBrokenImageDocument) {
   String mhtml = generateMHTMLParts("http://www.test.com", "broken-image.png",
                                     "image/png");
   EXPECT_TRUE(mhtml.isEmpty());
 }
 
 TEST_F(WebFrameSerializerSanitizationTest, ImageLoadedFromSrcsetForHiDPI) {
-  URLTestHelpers::registerMockedURLLoad(
-      KURL(ParsedURLString, "http://www.test.com/1x.png"),
-      "frameserialization/1x.png");
-  URLTestHelpers::registerMockedURLLoad(
-      KURL(ParsedURLString, "http://www.test.com/2x.png"),
-      "frameserialization/2x.png");
+  registerMockedFileURLLoad(KURL(ParsedURLString, "http://www.test.com/1x.png"),
+                            "frameserialization/1x.png");
+  registerMockedFileURLLoad(KURL(ParsedURLString, "http://www.test.com/2x.png"),
+                            "frameserialization/2x.png");
 
   // Set high DPR in order to load image from srcset, instead of src.
   webView()->setDeviceScaleFactor(2.0f);
 
   String mhtml = generateMHTMLParts("http://www.test.com", "img_srcset.html");
 
   // srcset attribute should be skipped.
   EXPECT_EQ(WTF::kNotFound, mhtml.find("srcset="));
 
   // Width and height attributes should be set when none is present in <img>.
   EXPECT_NE(WTF::kNotFound,
             mhtml.find("id=3D\"i1\" width=3D\"6\" height=3D\"6\">"));
 
   // Height attribute should not be set if width attribute is already present in
   // <img>
   EXPECT_NE(WTF::kNotFound, mhtml.find("id=3D\"i2\" width=3D\"8\">"));
 }
 
 TEST_F(WebFrameSerializerSanitizationTest, ImageLoadedFromSrcForNormalDPI) {
-  URLTestHelpers::registerMockedURLLoad(
-      KURL(ParsedURLString, "http://www.test.com/1x.png"),
-      "frameserialization/1x.png");
-  URLTestHelpers::registerMockedURLLoad(
-      KURL(ParsedURLString, "http://www.test.com/2x.png"),
-      "frameserialization/2x.png");
+  registerMockedFileURLLoad(KURL(ParsedURLString, "http://www.test.com/1x.png"),
+                            "frameserialization/1x.png");
+  registerMockedFileURLLoad(KURL(ParsedURLString, "http://www.test.com/2x.png"),
+                            "frameserialization/2x.png");
 
   String mhtml = generateMHTMLParts("http://www.test.com", "img_srcset.html");
 
   // srcset attribute should be skipped.
   EXPECT_EQ(WTF::kNotFound, mhtml.find("srcset="));
 
   // New width and height attributes should not be set.
   EXPECT_NE(WTF::kNotFound, mhtml.find("id=3D\"i1\">"));
   EXPECT_NE(WTF::kNotFound, mhtml.find("id=3D\"i2\" width=3D\"8\">"));
 }
 
 TEST_F(WebFrameSerializerSanitizationTest, RemovePopupOverlayIfRequested) {
   webView()->resize(WebSize(500, 500));
   setRemovePopupOverlay(true);
   String mhtml = generateMHTMLParts("http://www.test.com", "popup.html");
   EXPECT_EQ(WTF::kNotFound, mhtml.find("class=3D\"overlay"));
   EXPECT_EQ(WTF::kNotFound, mhtml.find("class=3D\"modal"));
 }
 
 TEST_F(WebFrameSerializerSanitizationTest, KeepPopupOverlayIfNotRequested) {
   webView()->resize(WebSize(500, 500));
   setRemovePopupOverlay(false);
   String mhtml = generateMHTMLParts("http://www.test.com", "popup.html");
   EXPECT_NE(WTF::kNotFound, mhtml.find("class=3D\"overlay"));
   EXPECT_NE(WTF::kNotFound, mhtml.find("class=3D\"modal"));
 }
 
 }  // namespace blink