platform/testing/{URL|Unit}TestHelpers improvements

third_party/WebKit/Source/web/LinkHighlightImplTest.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *     notice, this list of conditions and the following disclaimer in the
@@ skipping 15 matching lines @@
 #include "web/LinkHighlightImpl.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/dom/Node.h"
 #include "core/frame/FrameView.h"
 #include "core/input/EventHandler.h"
 #include "core/page/Page.h"
 #include "core/page/TouchDisambiguation.h"
 #include "platform/geometry/IntRect.h"
 #include "platform/testing/URLTestHelpers.h"
+#include "platform/testing/UnitTestHelpers.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebContentLayer.h"
 #include "public/platform/WebFloatPoint.h"
 #include "public/platform/WebInputEvent.h"
 #include "public/platform/WebSize.h"
 #include "public/platform/WebURLLoaderMockFactory.h"
 #include "public/web/WebCache.h"
 #include "public/web/WebFrame.h"
 #include "public/web/WebFrameClient.h"
 #include "public/web/WebViewClient.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "web/WebInputEventConversion.h"
 #include "web/WebLocalFrameImpl.h"
 #include "web/WebViewImpl.h"
 #include "web/tests/FrameTestHelpers.h"
 #include "wtf/PtrUtil.h"
 #include <memory>
 
 namespace blink {
 
+namespace {
+
 GestureEventWithHitTestResults getTargetedEvent(WebViewImpl* webViewImpl,
                                                 WebGestureEvent& touchEvent) {
   WebGestureEvent scaledEvent = TransformWebGestureEvent(
       webViewImpl->mainFrameImpl()->frameView(), touchEvent);
   return webViewImpl->page()
       ->deprecatedLocalMainFrame()
       ->eventHandler()
       .targetGestureEvent(scaledEvent, true);
 }
 
+std::string registerMockedURLLoad() {
+  WebURL url = URLTestHelpers::registerMockedURLLoadFromBase(
+      WebString::fromUTF8("http://www.test.com/"), testing::webTestDataPath(),
+      WebString::fromUTF8("test_touch_link_highlight.html"));
+  return url.string().utf8();
+}
+
+}  // namespace
+
 TEST(LinkHighlightImplTest, verifyWebViewImplIntegration) {
-  const std::string baseURL("http://www.test.com/");
-  const std::string fileName("test_touch_link_highlight.html");
-
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(baseURL.c_str()),
-      WebString::fromUTF8("test_touch_link_highlight.html"));
+  const std::string url = registerMockedURLLoad();
   FrameTestHelpers::WebViewHelper webViewHelper;
-  WebViewImpl* webViewImpl =
-      webViewHelper.initializeAndLoad(baseURL + fileName, true);
+  WebViewImpl* webViewImpl = webViewHelper.initializeAndLoad(url, true);
   int pageWidth = 640;
   int pageHeight = 480;
   webViewImpl->resize(WebSize(pageWidth, pageHeight));
   webViewImpl->updateAllLifecyclePhases();
 
   WebGestureEvent touchEvent(WebInputEvent::GestureShowPress,
                              WebInputEvent::NoModifiers,
                              WebInputEvent::TimeStampForTesting);
   touchEvent.sourceDevice = WebGestureDeviceTouchscreen;
 
@@ skipping 48 matching lines @@
 };
 
 FakeCompositingWebViewClient* compositingWebViewClient() {
   DEFINE_STATIC_LOCAL(FakeCompositingWebViewClient, client, ());
   return &client;
 }
 
 }  // anonymous namespace
 
 TEST(LinkHighlightImplTest, resetDuringNodeRemoval) {
-  const std::string baseURL("http://www.test.com/");
-  const std::string fileName("test_touch_link_highlight.html");
-
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(baseURL.c_str()),
-      WebString::fromUTF8("test_touch_link_highlight.html"));
+  const std::string url = registerMockedURLLoad();
   FrameTestHelpers::WebViewHelper webViewHelper;
-  WebViewImpl* webViewImpl = webViewHelper.initializeAndLoad(
-      baseURL + fileName, true, 0, compositingWebViewClient());
+  WebViewImpl* webViewImpl =
+      webViewHelper.initializeAndLoad(url, true, 0, compositingWebViewClient());
 
   int pageWidth = 640;
   int pageHeight = 480;
   webViewImpl->resize(WebSize(pageWidth, pageHeight));
   webViewImpl->updateAllLifecyclePhases();
 
   WebGestureEvent touchEvent(WebInputEvent::GestureShowPress,
                              WebInputEvent::NoModifiers,
                              WebInputEvent::TimeStampForTesting);
   touchEvent.sourceDevice = WebGestureDeviceTouchscreen;
@@ skipping 19 matching lines @@
 
   Platform::current()->getURLLoaderMockFactory()->unregisterAllURLs();
   WebCache::clear();
 }
 
 // A lifetime test: delete LayerTreeView while running LinkHighlights.
 TEST(LinkHighlightImplTest, resetLayerTreeView) {
   std::unique_ptr<FakeCompositingWebViewClient> webViewClient =
       WTF::makeUnique<FakeCompositingWebViewClient>();
 
-  const std::string baseURL("http://www.test.com/");
-  const std::string fileName("test_touch_link_highlight.html");
-
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(baseURL.c_str()),
-      WebString::fromUTF8("test_touch_link_highlight.html"));
+  const std::string url = registerMockedURLLoad();
   FrameTestHelpers::WebViewHelper webViewHelper;
-  WebViewImpl* webViewImpl = webViewHelper.initializeAndLoad(
-      baseURL + fileName, true, 0, webViewClient.get());
+  WebViewImpl* webViewImpl =
+      webViewHelper.initializeAndLoad(url, true, 0, webViewClient.get());
 
   int pageWidth = 640;
   int pageHeight = 480;
   webViewImpl->resize(WebSize(pageWidth, pageHeight));
   webViewImpl->updateAllLifecyclePhases();
 
   WebGestureEvent touchEvent(WebInputEvent::GestureShowPress,
                              WebInputEvent::NoModifiers,
                              WebInputEvent::TimeStampForTesting);
   touchEvent.sourceDevice = WebGestureDeviceTouchscreen;
@@ skipping 15 matching lines @@
 
   // Mimic the logic from RenderWidget::Close:
   webViewImpl->willCloseLayerTreeView();
   webViewHelper.reset();
 
   Platform::current()->getURLLoaderMockFactory()->unregisterAllURLs();
   WebCache::clear();
 }
 
 TEST(LinkHighlightImplTest, multipleHighlights) {
-  const std::string baseURL("http://www.test.com/");
-  const std::string fileName("test_touch_link_highlight.html");
-
-  URLTestHelpers::registerMockedURLFromBaseURL(
-      WebString::fromUTF8(baseURL.c_str()),
-      WebString::fromUTF8("test_touch_link_highlight.html"));
+  const std::string url = registerMockedURLLoad();
   FrameTestHelpers::WebViewHelper webViewHelper;
-  WebViewImpl* webViewImpl = webViewHelper.initializeAndLoad(
-      baseURL + fileName, true, 0, compositingWebViewClient());
+  WebViewImpl* webViewImpl =
+      webViewHelper.initializeAndLoad(url, true, 0, compositingWebViewClient());
 
   int pageWidth = 640;
   int pageHeight = 480;
   webViewImpl->resize(WebSize(pageWidth, pageHeight));
   webViewImpl->updateAllLifecyclePhases();
 
   WebGestureEvent touchEvent;
   touchEvent.x = 50;
   touchEvent.y = 310;
   touchEvent.data.tap.width = 30;
   touchEvent.data.tap.height = 30;
 
   Vector<IntRect> goodTargets;
   HeapVector<Member<Node>> highlightNodes;
   IntRect boundingBox(touchEvent.x - touchEvent.data.tap.width / 2,
                       touchEvent.y - touchEvent.data.tap.height / 2,
                       touchEvent.data.tap.width, touchEvent.data.tap.height);
   findGoodTouchTargets(boundingBox, webViewImpl->mainFrameImpl()->frame(),
                        goodTargets, highlightNodes);
 
   webViewImpl->enableTapHighlights(highlightNodes);
   EXPECT_EQ(2U, webViewImpl->numLinkHighlights());
 
   Platform::current()->getURLLoaderMockFactory()->unregisterAllURLs();
   WebCache::clear();
 }
 
 }  // namespace blink