platform/testing/{URL|Unit}TestHelpers improvements

third_party/WebKit/Source/platform/testing/URLTestHelpers.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 12 matching lines @@
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "platform/testing/URLTestHelpers.h"
 
+#include "base/files/file_path.h"
+#include "base/files/file_util.h"
 #include "platform/testing/UnitTestHelpers.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebURL.h"
 #include "public/platform/WebURLError.h"
 #include "public/platform/WebURLLoadTiming.h"
 #include "public/platform/WebURLLoaderMockFactory.h"
 #include "public/platform/WebURLResponse.h"
+#include <string>
 
 namespace blink {
 namespace URLTestHelpers {
 
-void registerMockedURLFromBaseURL(const WebString& baseURL,
-                                  const WebString& fileName,
-                                  const WebString& mimeType) {
+WebURL registerMockedURLLoadFromBase(const WebString& baseURL,
+                                     const WebString& basePath,
+                                     const WebString& fileName,
+                                     const WebString& mimeType) {
   // fullURL = baseURL + fileName.
-  std::string fullString =
+  std::string fullURL =
       std::string(baseURL.utf8().data()) + std::string(fileName.utf8().data());
-  registerMockedURLLoad(toKURL(fullString.c_str()), fileName,
-                        WebString::fromUTF8(""), mimeType);
+
+  // filePath = basePath + ("/" +) fileName.
+  base::FilePath filePath =
+      base::FilePath(basePath.utf8().data())

[kinuko, 2017/01/26 09:32:41]

Let's use WebStringToFilePath()

[Takashi Toyoshima, 2017/01/26 10:57:57]

Thanks, correct conversion looks more complicated than I thought.

+          .Append(FILE_PATH_LITERAL(fileName.utf8().data()));

[kinuko, 2017/01/26 09:32:40]

Ditto

[Takashi Toyoshima, 2017/01/26 10:57:57]

Done.

+
+  KURL url = toKURL(fullURL);
+  registerMockedURLLoad(url, String(filePath.AsUTF8Unsafe().c_str()), mimeType);

[kinuko, 2017/01/26 09:32:41]

FilePathToWebString

[Takashi Toyoshima, 2017/01/26 10:57:57]

Done.

+  return WebURL(url);
 }
 
 void registerMockedURLLoad(const WebURL& fullURL,
-                           const WebString& fileName,
-                           const WebString& mimeType) {
-  registerMockedURLLoad(fullURL, fileName, WebString::fromUTF8(""), mimeType);
-}
-
-void registerMockedURLLoad(const WebURL& fullURL,
-                           const WebString& fileName,
-                           const WebString& relativeBaseDirectory,
+                           const WebString& filePath,
                            const WebString& mimeType) {
   WebURLLoadTiming timing;
   timing.initialize();
 
   WebURLResponse response(fullURL);
   response.setMIMEType(mimeType);
   response.setHTTPStatusCode(200);
   response.setLoadTiming(timing);
 
-  registerMockedURLLoadWithCustomResponse(fullURL, fileName,
-                                          relativeBaseDirectory, response);
+  registerMockedURLLoadWithCustomResponse(fullURL, filePath, response);
 }
 
 void registerMockedErrorURLLoad(const WebURL& fullURL) {
   WebURLLoadTiming timing;
   timing.initialize();
 
   WebURLResponse response;
   response.setMIMEType("image/png");
   response.setHTTPStatusCode(404);
   response.setLoadTiming(timing);
 
   WebURLError error;
   error.reason = 404;
   Platform::current()->getURLLoaderMockFactory()->registerErrorURL(
       fullURL, response, error);
 }
 
-void registerMockedURLLoadWithCustomResponse(
-    const WebURL& fullURL,
-    const WebString& fileName,
-    const WebString& relativeBaseDirectory,
-    WebURLResponse response) {
-  // Physical file path for the mock =
-  // <webkitRootDir> + relativeBaseDirectory + fileName.
-  String filePath = testing::blinkRootDir();
-  filePath.append("/Source/web/tests/data/");
-  filePath.append(relativeBaseDirectory);
-  filePath.append(fileName);
-
+void registerMockedURLLoadWithCustomResponse(const WebURL& fullURL,
+                                             const WebString& filePath,
+                                             WebURLResponse response) {
   Platform::current()->getURLLoaderMockFactory()->registerURL(fullURL, response,
                                                               filePath);
 }
 
 }  // namespace URLTestHelpers
 }  // namespace blink