Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Side by Side Diff: Source/core/rendering/RenderBox.cpp

Issue 265493010: ASSERTION FAILED: overflowX() != OVISIBLE || overflowX() == overflowY() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/resolver/StyleAdjuster.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved. 7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
268 bool isRootObject = isDocumentElement(); 268 bool isRootObject = isDocumentElement();
269 bool isViewObject = isRenderView(); 269 bool isViewObject = isRenderView();
270 270
271 // The root and the RenderView always paint their backgrounds/borders. 271 // The root and the RenderView always paint their backgrounds/borders.
272 if (isRootObject || isViewObject) 272 if (isRootObject || isViewObject)
273 setHasBoxDecorationBackground(true); 273 setHasBoxDecorationBackground(true);
274 274
275 setFloating(!isOutOfFlowPositioned() && styleToUse->isFloating()); 275 setFloating(!isOutOfFlowPositioned() && styleToUse->isFloating());
276 276
277 bool boxHasOverflowClip = false; 277 bool boxHasOverflowClip = false;
278 if (!styleToUse->isOverflowVisible() && isRenderBlock() && !isViewObject) { 278 if (!styleToUse->isOverflowVisible() && isRenderBlock() && !isTable() && !is ViewObject) {
279 // If overflow has been propagated to the viewport, it has no effect her e. 279 // If overflow has been propagated to the viewport, it has no effect her e.
280 if (node() != document().viewportDefiningElement()) 280 if (node() != document().viewportDefiningElement())
281 boxHasOverflowClip = true; 281 boxHasOverflowClip = true;
282 } 282 }
283 283
284 if (boxHasOverflowClip != hasOverflowClip()) { 284 if (boxHasOverflowClip != hasOverflowClip()) {
285 // FIXME: This shouldn't be required if we tracked the visual overflow 285 // FIXME: This shouldn't be required if we tracked the visual overflow
286 // generated by positioned children or self painting layers. crbug.com/3 45403 286 // generated by positioned children or self painting layers. crbug.com/3 45403
287 for (RenderObject* child = slowFirstChild(); child; child = child->nextS ibling()) 287 for (RenderObject* child = slowFirstChild(); child; child = child->nextS ibling())
288 child->setMayNeedPaintInvalidation(true); 288 child->setMayNeedPaintInvalidation(true);
(...skipping 4138 matching lines...) Expand 10 before | Expand all | Expand 10 after
4427 4427
4428 setLogicalTop(oldLogicalTop); 4428 setLogicalTop(oldLogicalTop);
4429 setLogicalWidth(oldLogicalWidth); 4429 setLogicalWidth(oldLogicalWidth);
4430 setMarginLeft(oldMarginLeft); 4430 setMarginLeft(oldMarginLeft);
4431 setMarginRight(oldMarginRight); 4431 setMarginRight(oldMarginRight);
4432 4432
4433 return borderBox; 4433 return borderBox;
4434 } 4434 }
4435 4435
4436 } // namespace blink 4436 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/css/resolver/StyleAdjuster.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698