Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2654913003: [Devtools] Fixed scrolling in network panel (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
index 7dc4d44a27b2aa373a0413b21a8b67c3accd6b10..97f7f46af56fd12d29efa8a4f5818b93e71a1f60 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
@@ -173,7 +173,11 @@ Network.NetworkLogViewColumns = class {
return;
this._waterfallScrollerContent.style.height = this._dataGridScroller.scrollHeight + 'px';
this._updateScrollerWidthIfNeeded();
- this._dataGridScroller.scrollTop = this._waterfallScroller.scrollTop;
+ var scrollDifference = this._dataGridScroller.scrollTop - this._waterfallScroller.scrollTop;
+ // Ensure we scroll by at least 3 px because of rounding. See: Element.prototype.isScrolledToBottom
+ if (Math.abs(scrollDifference) < 3)
+ scrollDifference = -3;
luoe 2017/01/25 17:07:06 If we check just based on scrollDifference, we may
allada 2017/01/25 22:38:54 Done.
+ this._dataGridScroller.scrollTop -= scrollDifference;
}
_updateScrollerWidthIfNeeded() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698