Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: ui/gfx/render_text.cc

Issue 2654853002: Remove gfx::Canvas::DrawStringRectWithHalo. (Closed)
Patch Set: fix test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/render_text.h ('k') | ui/gfx/test/data/compositor/string_with_halo.png » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text.cc
diff --git a/ui/gfx/render_text.cc b/ui/gfx/render_text.cc
index 42cb2a3b2cb84653c3dc31546a334818a9a0bf10..2f331567f07ec620a40e47aa57414d42a6cf6b1b 100644
--- a/ui/gfx/render_text.cc
+++ b/ui/gfx/render_text.cc
@@ -25,7 +25,6 @@
#include "third_party/skia/include/core/SkFontStyle.h"
#include "third_party/skia/include/core/SkTypeface.h"
#include "third_party/skia/include/effects/SkGradientShader.h"
-#include "third_party/skia/include/effects/SkMorphologyImageFilter.h"
#include "ui/gfx/canvas.h"
#include "ui/gfx/geometry/insets.h"
#include "ui/gfx/geometry/safe_integer_conversions.h"
@@ -259,10 +258,6 @@ void SkiaTextRenderer::SetShader(sk_sp<SkShader> shader) {
flags_.setShader(cc::WrapSkShader(std::move(shader)));
}
-void SkiaTextRenderer::SetHaloEffect() {
- flags_.setImageFilter(SkDilateImageFilter::Make(1, 1, nullptr));
-}
-
void SkiaTextRenderer::SetUnderlineMetrics(SkScalar thickness,
SkScalar position) {
underline_thickness_ = thickness;
@@ -865,8 +860,6 @@ void RenderText::Draw(Canvas* canvas) {
if (!text().empty()) {
internal::SkiaTextRenderer renderer(canvas);
- if (halo_effect())
- renderer.SetHaloEffect();
DrawVisualText(&renderer);
}
« no previous file with comments | « ui/gfx/render_text.h ('k') | ui/gfx/test/data/compositor/string_with_halo.png » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698