Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Unified Diff: ui/gfx/render_text.cc

Issue 2654853002: Remove gfx::Canvas::DrawStringRectWithHalo. (Closed)
Patch Set: msw review Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/render_text.cc
diff --git a/ui/gfx/render_text.cc b/ui/gfx/render_text.cc
index 3b36ea0b3fea9d6ad80cce7cdc52272976169f97..1cee2e013f5edd3da2312f30e1f1206fefbcf455 100644
--- a/ui/gfx/render_text.cc
+++ b/ui/gfx/render_text.cc
@@ -23,7 +23,6 @@
#include "third_party/skia/include/core/SkFontStyle.h"
#include "third_party/skia/include/core/SkTypeface.h"
#include "third_party/skia/include/effects/SkGradientShader.h"
-#include "third_party/skia/include/effects/SkMorphologyImageFilter.h"
#include "ui/gfx/canvas.h"
#include "ui/gfx/geometry/insets.h"
#include "ui/gfx/geometry/safe_integer_conversions.h"
@@ -252,10 +251,6 @@ void SkiaTextRenderer::SetShader(sk_sp<SkShader> shader) {
paint_.setShader(std::move(shader));
}
-void SkiaTextRenderer::SetHaloEffect() {
- paint_.setImageFilter(SkDilateImageFilter::Make(1, 1, nullptr));
-}
-
void SkiaTextRenderer::SetUnderlineMetrics(SkScalar thickness,
SkScalar position) {
underline_thickness_ = thickness;
@@ -865,8 +860,6 @@ void RenderText::Draw(Canvas* canvas) {
if (!text().empty()) {
internal::SkiaTextRenderer renderer(canvas);
- if (halo_effect())
- renderer.SetHaloEffect();
DrawVisualText(&renderer);
}

Powered by Google App Engine
This is Rietveld 408576698