Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.h

Issue 2654843004: Fix shouldPaint issue when a composited floating iframe becomes non-self-painting (Closed)
Patch Set: Rename setAncestorShouldPaintFloatingObject to updateAncestorShouldPaintFloatingObject Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayer.h
diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.h b/third_party/WebKit/Source/core/paint/PaintLayer.h
index f57327cb49e3d2069ecee19945971cf364253502..75eb3c313e0786812a9dc768b5bb62af03821bcb 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayer.h
+++ b/third_party/WebKit/Source/core/paint/PaintLayer.h
@@ -250,10 +250,6 @@ class CORE_EXPORT PaintLayer : public DisplayItemClient {
// FIXME: Many people call this function while it has out-of-date information.
bool isSelfPaintingLayer() const { return m_isSelfPaintingLayer; }
- // PaintLayers which represent LayoutParts may become self-painting due to
- // being composited. If this is the case, this method returns true.
- bool isSelfPaintingOnlyBecauseIsCompositedPart() const;
-
bool isTransparent() const {
return layoutObject()->isTransparent() ||
layoutObject()->style()->hasBlendMode() || layoutObject()->hasMask();
@@ -988,6 +984,17 @@ class CORE_EXPORT PaintLayer : public DisplayItemClient {
return m_has3DTransformedDescendant;
}
+ // Whether the value of isSelfPaintingLayer() changed since the last clearing
+ // (which happens after the flag is chedked during compositing update).
+ bool selfPaintingStatusChanged() const {
+ DCHECK(!RuntimeEnabledFeatures::slimmingPaintV2Enabled());
+ return m_selfPaintingStatusChanged;
+ }
+ void clearSelfPaintingStatusChanged() {
+ DCHECK(!RuntimeEnabledFeatures::slimmingPaintV2Enabled());
+ m_selfPaintingStatusChanged = false;
+ }
+
#if CHECK_DISPLAY_ITEM_CLIENT_ALIVENESS
void endShouldKeepAliveAllClientsRecursive();
#endif
@@ -1115,8 +1122,6 @@ class CORE_EXPORT PaintLayer : public DisplayItemClient {
layer.m_needsPaintPhaseDescendantBlockBackgrounds;
}
- bool isSelfPaintingLayerForIntrinsicOrScrollingReasons() const;
-
bool shouldFragmentCompositedBounds(const PaintLayer* compositingLayer) const;
void expandRectForStackingChildren(const PaintLayer& compositedLayer,
@@ -1199,6 +1204,8 @@ class CORE_EXPORT PaintLayer : public DisplayItemClient {
unsigned m_hasAncestorWithClipPath : 1;
unsigned m_hasRootScrollerAsDescendant : 1;
+ unsigned m_selfPaintingStatusChanged : 1;
+
LayoutBoxModelObject* m_layoutObject;
PaintLayer* m_parent;
« no previous file with comments | « third_party/WebKit/Source/core/paint/BlockFlowPainter.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698