third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp - Issue 2654843004: Fix shouldPaint issue when a composited floating iframe becomes non-self-painting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

Issue 2654843004: Fix shouldPaint issue when a composited floating iframe becomes non-self-painting (Closed)

Patch Set: Rename setAncestorShouldPaintFloatingObject to updateAncestorShouldPaintFloatingObject Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp ('k') | third_party/WebKit/Source/core/paint/BlockFlowPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

index 2c1b53b27dbd9d6f53d47e6f670e8dd1b9193b85..dbfd4cf3e2ead3dea2ba5451feee795c53260215 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

@@ -247,6 +247,17 @@ void CompositingInputsUpdater::updateRecursive(PaintLayer* layer,

layer->didUpdateCompositingInputs();

m_geometryMap.popMappingsToAncestor(layer->parent());

+ if (layer->selfPaintingStatusChanged()) {

+ layer->clearSelfPaintingStatusChanged();

+ // If the floating object becomes non-self-painting, so some ancestor should

+ // paint it; if it becomes self-painting, it should paint itself and no

+ // ancestor should paint it.

+ if (layer->layoutObject()->isFloating()) {

+ LayoutBlockFlow::updateAncestorShouldPaintFloatingObject(

+ *layer->layoutBox());

+ }

}

#if DCHECK_IS_ON()