third_party/WebKit/Source/core/layout/LayoutBlockFlow.h - Issue 2654843004: Fix shouldPaint issue when a composited floating iframe becomes non-self-painting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

Issue 2654843004: Fix shouldPaint issue when a composited floating iframe becomes non-self-painting (Closed)

Patch Set: Rename setAncestorShouldPaintFloatingObject to updateAncestorShouldPaintFloatingObject Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

index d45ad3a01583b5bdd77126baa85b30290c376f6c..02673059b9ffd60d60c5c51aba21e5e71c505f4c 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

@@ -718,7 +718,8 @@ class CORE_EXPORT LayoutBlockFlow : public LayoutBlock {

return m_floatingObjects.get();

}

- static void setAncestorShouldPaintFloatingObject(const LayoutBox& floatBox);

+ static void updateAncestorShouldPaintFloatingObject(

+ const LayoutBox& floatBox);

protected:

LayoutUnit maxPositiveMarginBefore() const {