Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: components/ukm/ukm_service_unittest.cc

Issue 2654843003: Added UkmPageLoadMetricsObserver which sends top-level metrics to UKM (Closed)
Patch Set: Test fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ukm/ukm_service_unittest.cc
diff --git a/components/ukm/ukm_service_unittest.cc b/components/ukm/ukm_service_unittest.cc
index 0b80e5ccee573849cf70429ec2c1e271a4460db9..9827c8f042d0fdafdfcf60b8b2b8ccf3165c252a 100644
--- a/components/ukm/ukm_service_unittest.cc
+++ b/components/ukm/ukm_service_unittest.cc
@@ -107,8 +107,6 @@ TEST_F(UkmServiceTest, SourceSerialization) {
std::unique_ptr<UkmSource> source = base::WrapUnique(new UkmSource());
source->set_committed_url(GURL("https://google.com"));
- base::Time test_time;
- source->set_navigation_start(test_time);
source->set_first_contentful_paint(base::TimeDelta::FromMilliseconds(300));
service.RecordSource(std::move(source));
@@ -121,10 +119,6 @@ TEST_F(UkmServiceTest, SourceSerialization) {
const Source& proto_source = proto_report.sources(0);
EXPECT_EQ(GURL("https://google.com").spec(), proto_source.url());
- base::Time navigation_time =
- base::Time::UnixEpoch() +
- base::TimeDelta::FromMilliseconds(proto_source.navigation_time_msec());
- EXPECT_EQ(test_time, navigation_time);
EXPECT_EQ(300, proto_source.first_contentful_paint_msec());
}

Powered by Google App Engine
This is Rietveld 408576698