Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

Issue 2654843003: Added UkmPageLoadMetricsObserver which sends top-level metrics to UKM (Closed)
Patch Set: Test fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
index b1b1d7fd032d766acc24778316e575682c60a31d..9eea0c7fe36eaafae45886b5bc53873e346c6a6d 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
+++ b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
@@ -25,6 +25,7 @@
#include "chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.h"
#include "chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h"
#include "chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h"
+#include "chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h"
#include "chrome/browser/page_load_metrics/page_load_metrics_embedder_interface.h"
#include "chrome/browser/page_load_metrics/page_load_tracker.h"
#include "chrome/browser/prerender/prerender_contents.h"
@@ -85,6 +86,12 @@ void PageLoadMetricsEmbedder::RegisterObservers(
web_contents_->GetBrowserContext()));
tracker->AddObserver(base::MakeUnique<CssScanningMetricsObserver>());
tracker->AddObserver(base::MakeUnique<ProtocolPageLoadMetricsObserver>());
+
+ std::unique_ptr<page_load_metrics::PageLoadMetricsObserver> ukm_observer =
+ UkmPageLoadMetricsObserver::CreateIfNeeded();
+ if (ukm_observer)
+ tracker->AddObserver(std::move(ukm_observer));
+
std::unique_ptr<page_load_metrics::PageLoadMetricsObserver>
no_state_prefetch_observer =
NoStatePrefetchPageLoadMetricsObserver::CreateIfNeeded(

Powered by Google App Engine
This is Rietveld 408576698