Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1624)

Unified Diff: test/mjsunit/array-constructor-feedback.js

Issue 2654733004: [tests] Make assertOptimized()/assertUnoptimized() great again. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/mjsunit/array-constructor-feedback.js
diff --git a/test/mjsunit/array-constructor-feedback.js b/test/mjsunit/array-constructor-feedback.js
index 865b8ba44fc06bcfcdbe3105fae0c067bf0ba281..ff8821a7979f8504052c0512863dd7927586deaf 100644
--- a/test/mjsunit/array-constructor-feedback.js
+++ b/test/mjsunit/array-constructor-feedback.js
@@ -84,7 +84,8 @@ function assertKind(expected, obj, name_opt) {
%OptimizeFunctionOnNextCall(bar0);
b = bar0(Array);
// This only makes sense to test if we allow crankshafting
- if (4 != %GetOptimizationStatus(bar0)) {
+ var opt_status = %GetOptimizationStatus(bar0);
+ if ((opt_status & V8OptimizationStatus.kNeverOptimize) === 0) {
// We also lost our ability to record kind feedback, as the site
// is megamorphic now.
assertKind(elements_kind.fast_smi_only, b);
@@ -144,7 +145,8 @@ function assertKind(expected, obj, name_opt) {
%OptimizeFunctionOnNextCall(bar);
b = bar();
// This only makes sense to test if we allow crankshafting
- if (4 != %GetOptimizationStatus(bar)) {
+ var opt_status = %GetOptimizationStatus(bar);
+ if ((opt_status & V8OptimizationStatus.kNeverOptimize) === 0) {
assertOptimized(bar);
%DebugPrint(3);
b[0] = 3.5;
@@ -193,7 +195,8 @@ function assertKind(expected, obj, name_opt) {
assertOptimized(bar);
// Crankshafted functions don't use mementos, so feedback still
// indicates a packed array is desired. (unless --nocrankshaft is in use).
- if (4 != %GetOptimizationStatus(bar)) {
+ var opt_status = %GetOptimizationStatus(bar);
+ if ((opt_status & V8OptimizationStatus.kNeverOptimize) === 0) {
assertFalse(isHoley(a));
}
})();

Powered by Google App Engine
This is Rietveld 408576698