Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: test/mjsunit/es6/array-iterator-turbo.js

Issue 2654733004: [tests] Make assertOptimized()/assertUnoptimized() great again. (Closed)
Patch Set: Rebasing for relanding Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/mjsunit/es6/array-iterator-turbo.js
diff --git a/test/mjsunit/es6/array-iterator-turbo.js b/test/mjsunit/es6/array-iterator-turbo.js
index 0fa36dcda0245bc074e0786c9dec639a6134b21a..39c46575a6e927b3392b321704f706fde5d30286 100644
--- a/test/mjsunit/es6/array-iterator-turbo.js
+++ b/test/mjsunit/es6/array-iterator-turbo.js
@@ -6,21 +6,6 @@
"use strict";
-const kDeoptimized = 2;
-const kTurbofanned = 7;
-const kInterpreted = 8;
-
-function GetOptimizationStatus(fn) {
- let status = %GetOptimizationStatus(fn);
- switch (status) {
- case kInterpreted: // Treat interpreted frames as unoptimized
- status = kDeoptimized;
- break;
- }
-
- return status;
-}
-
let global = this;
let tests = {
FastElementsKind() {
@@ -118,15 +103,27 @@ let tests = {
// TODO(bmeurer): FAST_HOLEY_DOUBLE_ELEMENTS maps generally deopt when
// a hole is encountered. Test should be fixed once that is corrected.
- let status = /HOLEY_DOUBLE/.test(key) ? kDeoptimized : kTurbofanned;
+ let expect_deopt = /HOLEY_DOUBLE/.test(key);
- assertEquals(status, GetOptimizationStatus(fn), key);
+ if (expect_deopt) {
+ assertUnoptimized(fn, '', key);
+ } else {
+ assertOptimized(fn, '', key);
+ }
assertEquals(expected, fn(array), key);
- assertEquals(status, GetOptimizationStatus(fn), key);
+ if (expect_deopt) {
+ assertUnoptimized(fn, '', key);
+ } else {
+ assertOptimized(fn, '', key);
+ }
- // Check no deopt when another arra with the same map is used
+ // Check no deopt when another array with the same map is used
assertTrue(%HaveSameMap(array, array2), key);
- assertEquals(status, GetOptimizationStatus(fn), key);
+ if (expect_deopt) {
+ assertUnoptimized(fn, '', key);
+ } else {
+ assertOptimized(fn, '', key);
+ }
assertEquals(expected2, fn(array2), key);
// CheckMaps bailout
@@ -134,7 +131,7 @@ let tests = {
[1, 2, 3], 2, { enumerable: false, configurable: false,
get() { return 7; } });
fn(newArray);
- assertEquals(kDeoptimized, GetOptimizationStatus(fn), key);
+ assertUnoptimized(fn, '', key);
}
},
@@ -222,12 +219,12 @@ let tests = {
%OptimizeFunctionOnNextCall(sum);
assertEquals(expected, sum(array), key);
- assertEquals(kTurbofanned, GetOptimizationStatus(sum), key);
+ assertOptimized(sum, '', key);
// Not deoptimized when called on typed array of same type / map
assertTrue(%HaveSameMap(array, array2));
assertEquals(expected2, sum(array2), key);
- assertEquals(kTurbofanned, GetOptimizationStatus(sum), key);
+ assertOptimized(sum, '', key);
// Throw when detached
let clone = new array.constructor(array);

Powered by Google App Engine
This is Rietveld 408576698