Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: test/mjsunit/regress/regress-v8-5697.js

Issue 2654733004: [tests] Make assertOptimized()/assertUnoptimized() great again. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Flags: --allow-natives-syntax 5 // Flags: --allow-natives-syntax
6 6
7 function load(o) { return o.x; } 7 function load(o) { return o.x; }
8 8
9 for (var x = 0; x < 1000; ++x) { 9 for (var x = 0; x < 1000; ++x) {
10 load({x}); 10 load({x});
11 load({x}); 11 load({x});
12 % OptimizeFunctionOnNextCall(load);
Igor Sheludko 2017/01/25 11:38:42 Optimization of load() did not kick in with --igni
Michael Starzinger 2017/01/26 12:24:52 Is the loop still needed on this case?
Igor Sheludko 2017/01/26 14:12:30 Yes. The test checks that we don't have a deopt lo
12 try { load(); } catch (e) { } 13 try { load(); } catch (e) { }
13 } 14 }
14 15
15 assertOptimized(load); 16 assertOptimized(load);
16 17
17 18
18 function store(o) { o.x = -1; } 19 function store(o) { o.x = -1; }
19 20
20 for (var x = 0; x < 1000; ++x) { 21 for (var x = 0; x < 1000; ++x) {
21 store({x}); 22 store({x});
22 store({x}); 23 store({x});
24 % OptimizeFunctionOnNextCall(store);
Michael Starzinger 2017/01/26 12:24:52 Likewise.
23 try { store(); } catch (e) { } 25 try { store(); } catch (e) { }
24 } 26 }
25 27
26 assertOptimized(store); 28 assertOptimized(store);
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698