Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Side by Side Diff: test/mjsunit/compiler/concurrent-proto-change.js

Issue 2654733004: [tests] Make assertOptimized()/assertUnoptimized() great again. (Closed)
Patch Set: Rebasing for relanding Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // Flags: --allow-natives-syntax --no-always-opt 28 // Flags: --allow-natives-syntax --no-always-opt
29 // Flags: --concurrent-recompilation --block-concurrent-recompilation 29 // Flags: --concurrent-recompilation --block-concurrent-recompilation
30 // Flags: --no-always-opt
30 31
31 if (!%IsConcurrentRecompilationSupported()) { 32 if (!%IsConcurrentRecompilationSupported()) {
32 print("Concurrent recompilation is disabled. Skipping this test."); 33 print("Concurrent recompilation is disabled. Skipping this test.");
33 quit(); 34 quit();
34 } 35 }
35 36
36 function f(foo) { return foo.bar(); } 37 function f(foo) { return foo.bar(); }
37 38
38 var o = {}; 39 var o = {};
39 o.__proto__ = { __proto__: { bar: function() { return 1; } } }; 40 o.__proto__ = { __proto__: { bar: function() { return 1; } } };
40 41
41 assertEquals(1, f(o)); 42 assertEquals(1, f(o));
42 assertEquals(1, f(o)); 43 assertEquals(1, f(o));
43 44
44 // Mark for concurrent optimization. 45 // Mark for concurrent optimization.
45 %OptimizeFunctionOnNextCall(f, "concurrent"); 46 %OptimizeFunctionOnNextCall(f, "concurrent");
46 // Kick off recompilation. 47 // Kick off recompilation.
47 assertEquals(1, f(o)); 48 assertEquals(1, f(o));
48 // Change the prototype chain after compile graph has been created. 49 // Change the prototype chain after compile graph has been created.
49 o.__proto__.__proto__ = { bar: function() { return 2; } }; 50 o.__proto__.__proto__ = { bar: function() { return 2; } };
50 // At this point, concurrent recompilation thread has not yet done its job. 51 // At this point, concurrent recompilation thread has not yet done its job.
51 assertUnoptimized(f, "no sync"); 52 assertUnoptimized(f, "no sync");
52 // Let the background thread proceed. 53 // Let the background thread proceed.
53 %UnblockConcurrentRecompilation(); 54 %UnblockConcurrentRecompilation();
54 // Optimization eventually bails out due to map dependency. 55 // Optimization eventually bails out due to map dependency.
55 assertUnoptimized(f, "sync"); 56 assertUnoptimized(f, "sync");
56 assertEquals(2, f(o)); 57 assertEquals(2, f(o));
57 //Clear type info for stress runs. 58 //Clear type info for stress runs.
58 %ClearFunctionTypeFeedback(f); 59 %ClearFunctionTypeFeedback(f);
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698