[tests] Make assertOptimized()/assertUnoptimized() great again.

test/mjsunit/assert-opt-and-deopt.js

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 31 matching lines @@
 function OptTracker() {
   this.opt_counts_ = {};
 }
 
 /**
  * The possible optimization states of a function. Must be in sync with the
  * return values of Runtime_GetOptimizationStatus() in runtime.cc!
  * @enum {int}
  */
 OptTracker.OptimizationState = {
-    YES: 1,
-    NO: 2,
-    ALWAYS: 3,
-    NEVER: 4
+  kIsFunction: 1 << 0,

[Michael Starzinger, 2017/01/26 12:24:52]

suggestion: Could we map these to the existing constants in the mjsunit.js file
to have one less place that needs to be kept in sync? I am thinking along the
lines of ...

OptTracker.OptimizationState = {
  kIsFunction: V8OptimizationStatus.kIsFunction,
  ...
}

Or alternatively we could use the constant directly in the below test. WDYT?

[Igor Sheludko, 2017/01/26 14:12:31]

Given that this file already uses stuff from mjsunit.js it's really better to
just use V8OptimizationStatus here directly.

+  kNeverOptimize: 1 << 1,
+  kAlwaysOptimize: 1 << 2,
+  kMaybeDeopted: 1 << 3,
+  kOptimized: 1 << 4,
+  kTurboFanned: 1 << 5,
+  kInterpreted: 1 << 6
 };
 
 /**
  * Always call this at the beginning of your test, once for each function
  * that you later want to track de/optimizations for. It is necessary because
  * tests are sometimes executed several times in a row, and you want to
  * disregard counts from previous runs.
  */
 OptTracker.prototype.CheckpointOptCount = function(func) {
   this.opt_counts_[func] = %GetOptimizationCount(func);
@@ skipping 21 matching lines @@
     assertTrue(this.GetDeoptCount_(func) > 0);
   } else {
     assertEquals(0, this.GetDeoptCount_(func));
   }
 }
 
 OptTracker.prototype.AssertIsOptimized = function(func, expect_optimized) {
   if (this.DisableAsserts_(func)) {
     return;
   }
-  var raw_optimized = %GetOptimizationStatus(func);
-  if (expect_optimized) {
-    assertEquals(OptTracker.OptimizationState.YES, raw_optimized);
-  } else {
-    assertEquals(OptTracker.OptimizationState.NO, raw_optimized);
-  }
+  var opt_status = %GetOptimizationStatus(func);
+  assertTrue((opt_status & OptTracker.OptimizationState.kIsFunction) !== 0);
+  assertEquals(
+      expect_optimized,
+      (opt_status & OptTracker.OptimizationState.kOptimized) !== 0);
 }
 
 /**
  * @private
  */
 OptTracker.prototype.GetOptCount_ = function(func) {
   var raw_count = %GetOptimizationCount(func);
   if (func in this.opt_counts_) {
     var checkpointed_count = this.opt_counts_[func];
     return raw_count - checkpointed_count;
   }
   return raw_count;
 }
 
 /**
  * @private
  */
 OptTracker.prototype.GetDeoptCount_ = function(func) {
   var count = this.GetOptCount_(func);
-  if (%GetOptimizationStatus(func) == OptTracker.OptimizationState.YES) {
+  var opt_status = %GetOptimizationStatus(func);
+  if ((opt_status & OptTracker.OptimizationState.kOptimized) !== 0) {
     count -= 1;
   }
   return count;
 }
 
 /**
  * @private
  */
 OptTracker.prototype.DisableAsserts_ = function(func) {
-  switch(%GetOptimizationStatus(func)) {
-    case OptTracker.OptimizationState.YES:
-    case OptTracker.OptimizationState.NO:
-      return false;
-    case OptTracker.OptimizationState.ALWAYS:
-    case OptTracker.OptimizationState.NEVER:
-      return true;
-  }
-  return true;
+  var opt_status = %GetOptimizationStatus(func);
+  return (opt_status & OptTracker.OptimizationState.kAlwaysOptimize) !== 0 ||
+      (opt_status & OptTracker.OptimizationState.kNeverOptimize) !== 0;
 }
 // (End of class OptTracker.)
 
 // Example function used by the test below.
 function f(a) {
   return a+1;
 }
 
 var tracker = new OptTracker();
 tracker.CheckpointOptCount(f);
@@ skipping 23 matching lines @@
 // Let's trigger optimization for another type.
 for (var i = 0; i < 5; i++) f("a");
 
 %OptimizeFunctionOnNextCall(f);
 f("b");
 
 tracker.AssertOptCount(f, 2);
 tracker.AssertIsOptimized(f, true);
 tracker.AssertDeoptHappened(f, true);
 tracker.AssertDeoptCount(f, 1);