Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2654733003: Make Stream abstract as it is in the actual SDK. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make Stream abstract as it is in the actual SDK. This requires fixes for inference tests. R=brianwilkerson@google.com, jmesserly@google.com, leafp@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3e80ae9304b606c5cf9ba17d7644b4311dca20bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -18 lines) Patch
M pkg/analyzer/test/generated/analysis_context_factory.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_driver_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/context/mock_sdk.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 2 chunks +18 lines, -7 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 2 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-24 20:30:32 UTC) #1
Brian Wilkerson
lgtm
3 years, 11 months ago (2017-01-24 20:45:08 UTC) #2
scheglov
3 years, 11 months ago (2017-01-24 20:50:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3e80ae9304b606c5cf9ba17d7644b4311dca20bf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698