IDL compiler: [PerContextEnabled] for getters

IDL compiler: [PerContextEnabled] for getters

There is only one use of PerContextEnabled for attributes:
Source/core/page/WindowPagePopup.idl
[PerContextEnabled=PagePopup] readonly attribute PagePopupController pagePopupController;
...and 2 uses for operations:
Source/core/frame/History.idl

Longer-term, consider removing them.
It would be nice to get rid of these, as it's significant complexity to
support very limited use cases, but that would involve C++ changes.

I'm not implementing dual [RuntimeEnabled, PerContextEnabled]
or [Conditional, PerContextEnabled]
as these are not used in actual code;
also removing from Perl.

Other changes:
* Refactors attribute configuration in Jinja template into a macro,
since used 3 places
* Capitalizes Feature Names in PerContextEnabled values
* Fixes spacing in Perl CG

BUG=239771
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159774

[Nils Barth (inactive), 2013-10-16 05:06:15]

Special case, 1 real use.
2 questions:
1. Can we remove [PerContextEnabled] (longer term)?
2. Should I remove support for compound [PerContextEnabled, RuntimeEnabled] and
[Conditional, PerContextEnabled] from Perl CG?
(Not used in real IDLs, so not implementing in Python,
but someone might expect this to work;
safer and easier to just leave for now, I think.)

[haraken, 2013-10-16 05:28:06]

LGTM.

> 1. Can we remove [PerContextEnabled] (longer term)?

I'm not sure, because the concept of per-context-enabled is a general one and
thus will have use cases. You can ask the author of those 3
attributes/operations and discuss if you can remove them or not.

> 2. Should I remove support for compound [PerContextEnabled, RuntimeEnabled]
and
> [Conditional, PerContextEnabled] from Perl CG?

Yes. [Conditional] is deprecated. We should remove unnecessary complexity from
the code base.

https://codereview.chromium.org/26547005/diff/3001/Source/bindings/scripts/un...
File Source/bindings/scripts/unstable/v8_utilities.py (right):

https://codereview.chromium.org/26547005/diff/3001/Source/bindings/scripts/un...
Source/bindings/scripts/unstable/v8_utilities.py:150: return
'ContextFeatures::%sEnabled' % uncapitalize(feature_name)

We should rename ContextFeatures to PerContextEnabledFeatures in a follow-up.
(c.f., RuntimeEnabledFeatures)

https://codereview.chromium.org/26547005/diff/3001/Source/bindings/templates/...
File Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/26547005/diff/3001/Source/bindings/templates/...
Source/bindings/templates/interface.cpp:137: void
{{v8_class_name}}::installPerContextProperties(v8::Handle<v8::Object> instance,
{{cpp_class_name}}* impl, v8::Isolate* isolate)

installPerContextProperties => installPerContextEnabledAttributes ?

[Nils Barth (inactive), 2013-10-16 06:02:10]

On 2013/10/16 05:28:06, haraken wrote:
> > 1. Can we remove [PerContextEnabled] (longer term)?
> 
> I'm not sure, because the concept of per-context-enabled is a general one and
> thus will have use cases. You can ask the author of those 3
> attributes/operations and discuss if you can remove them or not.

Got it, that's what I thought.
I've put this in "TODO after rewrite".

> > 2. Should I remove support for compound [PerContextEnabled, RuntimeEnabled]
> and
> > [Conditional, PerContextEnabled] from Perl CG?
> 
> Yes. [Conditional] is deprecated. We should remove unnecessary complexity from
> the code base.

Got it, removed from Perl CG and test cases.
(Removes a lot of complexity.)

[Nils Barth (inactive), 2013-10-16 06:05:17]

Thanks, revised, will land after [Reflect] lands,
since needs rebasing and try bots (due to Perl CG changes).

https://codereview.chromium.org/26547005/diff/3001/Source/bindings/scripts/un...
File Source/bindings/scripts/unstable/v8_utilities.py (right):

https://codereview.chromium.org/26547005/diff/3001/Source/bindings/scripts/un...
Source/bindings/scripts/unstable/v8_utilities.py:150: return
'ContextFeatures::%sEnabled' % uncapitalize(feature_name)
On 2013/10/16 05:28:06, haraken wrote:
> We should rename ContextFeatures to PerContextEnabledFeatures in a follow-up.
> (c.f., RuntimeEnabledFeatures)

I'll look into this when I talk to people about removing these;
this is a Blink C++ change (Source/core/dom/ContextFeatures.h & .cpp),
not just bindings, so it's developer-visible.

https://codereview.chromium.org/26547005/diff/3001/Source/bindings/templates/...
File Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/26547005/diff/3001/Source/bindings/templates/...
Source/bindings/templates/interface.cpp:137: void
{{v8_class_name}}::installPerContextProperties(v8::Handle<v8::Object> instance,
{{cpp_class_name}}* impl, v8::Isolate* isolate)
On 2013/10/16 05:28:06, haraken wrote:
> installPerContextProperties => installPerContextEnabledAttributes ?

Done!
(Results in lots of test result changes.)

[commit-bot: I haz the power, 2013-10-16 10:59:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/26547005/13001

[commit-bot: I haz the power, 2013-10-16 11:01:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/26547005/18001

[commit-bot: I haz the power, 2013-10-16 14:26:18]

Change committed as 159774