Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: services/ui/surfaces/display_compositor.cc

Issue 2654693003: Decouple GpuCompositorFrameSink from DisplayCompositor (Closed)
Patch Set: Fix vars Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/surfaces/display_compositor.cc
diff --git a/services/ui/surfaces/display_compositor.cc b/services/ui/surfaces/display_compositor.cc
index a7d48a911204453ff41b58dfe7c05e51c865a009..ce837b39349a3f756a0958bd0e61a958d4b3da60 100644
--- a/services/ui/surfaces/display_compositor.cc
+++ b/services/ui/surfaces/display_compositor.cc
@@ -44,33 +44,12 @@ DisplayCompositor::DisplayCompositor(
manager_.AddObserver(this);
}
-void DisplayCompositor::AddSurfaceReferences(
- const std::vector<cc::SurfaceReference>& references) {
- DCHECK(thread_checker_.CalledOnValidThread());
- for (const auto& reference : references) {
- reference_manager_->AddSurfaceReference(reference.parent_id(),
- reference.child_id());
- }
-}
-
-void DisplayCompositor::RemoveSurfaceReferences(
- const std::vector<cc::SurfaceReference>& references) {
- DCHECK(thread_checker_.CalledOnValidThread());
-
- // TODO(kylechar): Each remove reference can trigger GC, it would be better if
- // we GC only once if removing multiple references.
- for (const auto& reference : references) {
- reference_manager_->RemoveSurfaceReference(reference.parent_id(),
- reference.child_id());
- }
-}
-
DisplayCompositor::~DisplayCompositor() {
DCHECK(thread_checker_.CalledOnValidThread());
manager_.RemoveObserver(this);
}
-void DisplayCompositor::OnCompositorFrameSinkClientConnectionLost(
+void DisplayCompositor::OnClientConnectionLost(
const cc::FrameSinkId& frame_sink_id,
bool destroy_compositor_frame_sink) {
DCHECK(thread_checker_.CalledOnValidThread());
@@ -81,7 +60,7 @@ void DisplayCompositor::OnCompositorFrameSinkClientConnectionLost(
// client instance to create a new CompositorFrameSink.
}
-void DisplayCompositor::OnCompositorFrameSinkPrivateConnectionLost(
+void DisplayCompositor::OnPrivateConnectionLost(
const cc::FrameSinkId& frame_sink_id,
bool destroy_compositor_frame_sink) {
DCHECK(thread_checker_.CalledOnValidThread());
@@ -108,7 +87,7 @@ void DisplayCompositor::CreateDisplayCompositorFrameSink(
compositor_frame_sinks_[frame_sink_id] =
base::MakeUnique<GpuDisplayCompositorFrameSink>(
- this, frame_sink_id, std::move(display),
+ this, &manager_, frame_sink_id, std::move(display),
std::move(begin_frame_source), std::move(request),
std::move(private_request), std::move(client),
std::move(display_private_request));
@@ -124,8 +103,8 @@ void DisplayCompositor::CreateOffscreenCompositorFrameSink(
compositor_frame_sinks_[frame_sink_id] =
base::MakeUnique<GpuOffscreenCompositorFrameSink>(
- this, frame_sink_id, std::move(request), std::move(private_request),
- std::move(client));
+ this, &manager_, frame_sink_id, std::move(request),
+ std::move(private_request), std::move(client));
}
std::unique_ptr<cc::Display> DisplayCompositor::CreateDisplay(

Powered by Google App Engine
This is Rietveld 408576698