Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2654663005: Add DeclaredVariables to AnalysisDriver. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -10 lines) Patch
M pkg/analyzer/lib/context/declared_variables.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 3 chunks +7 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_driver_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/constant/evaluation_test.dart View 3 chunks +18 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-24 18:28:37 UTC) #1
Brian Wilkerson
lgtm
3 years, 11 months ago (2017-01-24 18:38:54 UTC) #2
scheglov
3 years, 11 months ago (2017-01-24 18:57:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
decb720a0c1133c777de8f995c97e0fdf70e6ff8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698