First step toward resolving generic function types

First step toward resolving generic function types

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/0737b3d2be2753e63dc451d5bca65e592ac34da6

[Brian Wilkerson, 2017-01-24 16:32:00]

brianwilkerson@google.com changed reviewers:
+ jmesserly@google.com

[Brian Wilkerson, 2017-01-24 16:32:01]

I had already done this work before getting your offer to implement the
resolution of generic function types. If you think there's a better approach I'm
willing to drop this CL, but I thought I might as well get it in if you were
going to take on the rest of this task.

The basic approach I was taking was to make FunctionTypeImpl less dependent on
having an element (because I don't think we want to create elements for generic
function types). Obviously, that work isn't complete, but I think this is a good
first step.

[Brian Wilkerson, 2017-01-31 16:27:21]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-01-31 17:06:59]

lgtm

[Brian Wilkerson, 2017-01-31 17:56:32]

Description was changed from

==========
First step toward resolving generic function types
==========

to

==========
First step toward resolving generic function types

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0737b3d2be2753e63dc451d5bca65e592ac34da6
==========

[Brian Wilkerson, 2017-01-31 17:56:33]

Committed patchset #1 (id:1) manually as
0737b3d2be2753e63dc451d5bca65e592ac34da6 (presubmit successful).

[hausner, 2017-01-31 21:42:20]

hausner@google.com changed reviewers:
+ hausner@google.com

[hausner, 2017-01-31 21:42:21]

It seems this CL broke the vm-kernel buildbot. All tests fail with this error:

stderr:
'package:analyzer/src/dart/element/type.dart': error: line 436 pos 27: illegal
implicit access to receiver 'this'
      : _typeParameters = _explicitTypeParameters,

That line was added with this CL.

[Brian Wilkerson, 2017-01-31 21:43:49]

Yep. And the CL was reverted by https://codereview.chromium.org/2660403005/
pending some changes to the dartk build script.