|
|
Created:
6 years, 7 months ago by jcgregorio Modified:
6 years, 7 months ago Reviewers:
mtklein CC:
skia-review_googlegroups.com Base URL:
https://skia.googlesource.com/skia.git@master Visibility:
Public. |
DescriptionSet ulimits for the compile stage.
BUG=skia:
Committed: http://code.google.com/p/skia/source/detail?r=14483
Patch Set 1 #Patch Set 2 : #
Total comments: 4
Patch Set 3 : #Patch Set 4 : rebase #Messages
Total messages: 12 (0 generated)
https://codereview.chromium.org/265453010/diff/20001/experimental/webtry/safec++ File experimental/webtry/safec++ (right): https://codereview.chromium.org/265453010/diff/20001/experimental/webtry/safe... experimental/webtry/safec++:2: # Limit the amount of time and the core size for the compiler. set -e ? https://codereview.chromium.org/265453010/diff/20001/experimental/webtry/safe... experimental/webtry/safec++:4: ulimit -t 5 -c 1 Maybe just -c 0 if we're already willing to limit them to 1K?
https://codereview.chromium.org/265453010/diff/20001/experimental/webtry/safec++ File experimental/webtry/safec++ (right): https://codereview.chromium.org/265453010/diff/20001/experimental/webtry/safe... experimental/webtry/safec++:2: # Limit the amount of time and the core size for the compiler. On 2014/04/30 19:16:30, mtklein wrote: > set -e > ? Done. https://codereview.chromium.org/265453010/diff/20001/experimental/webtry/safe... experimental/webtry/safec++:4: ulimit -t 5 -c 1 On 2014/04/30 19:16:30, mtklein wrote: > Maybe just -c 0 if we're already willing to limit them to 1K? Done.
lgtm
The CQ bit was checked by jcgregorio@google.com
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/265453010/40001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for experimental/webtry/webtry.go: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file experimental/webtry/webtry.go Hunk #1 FAILED at 25. 1 out of 1 hunk FAILED -- saving rejects to file experimental/webtry/webtry.go.rej Patch: experimental/webtry/webtry.go Index: experimental/webtry/webtry.go diff --git a/experimental/webtry/webtry.go b/experimental/webtry/webtry.go index 79abaf1c1522ef89d2ba98007c0c6f30129af195..e6c76948dcedb66b1e0b285363f8b68de10b23a5 100644 --- a/experimental/webtry/webtry.go +++ b/experimental/webtry/webtry.go @@ -25,8 +25,8 @@ import ( ) const ( - RESULT_COMPILE = `c++ -DSK_GAMMA_SRGB -DSK_GAMMA_APPLY_TO_A8 -DSK_SCALAR_TO_FLOAT_EXCLUDED -DSK_ALLOW_STATIC_GLOBAL_INITIALIZERS=1 -DSK_SUPPORT_GPU=0 -DSK_SUPPORT_OPENCL=0 -DSK_FORCE_DISTANCEFIELD_FONTS=0 -DSK_SCALAR_IS_FLOAT -DSK_CAN_USE_FLOAT -DSK_SAMPLES_FOR_X -DSK_BUILD_FOR_UNIX -DSK_USE_POSIX_THREADS -DSK_SYSTEM_ZLIB=1 -DSK_DEBUG -DSK_DEVELOPER=1 -I../../src/core -I../../src/images -I../../tools/flags -I../../include/config -I../../include/core -I../../include/pathops -I../../include/pipe -I../../include/effects -I../../include/ports -I../../src/sfnt -I../../include/utils -I../../src/utils -I../../include/images -g -fno-exceptions -fstrict-aliasing -Wall -Wextra -Winit-self -Wpointer-arith -Wno-unused-parameter -Wno-c++11-extensions -Werror -m64 -fno-rtti -Wnon-virtual-dtor -c ../../../cache/%s.cpp -o ../../../cache/%s.o` - LINK = `c++ -m64 -lstdc++ -lm -o ../../../inout/%s -Wl,--start-group ../../../cache/%s.o obj/experimental/webtry/webtry.main.o obj/gyp/libflags.a libskia_images.a libskia_core.a libskia_effects.a obj/gyp/libjpeg.a obj/gyp/libwebp_dec.a obj/gyp/libwebp_demux.a obj/gyp/libwebp_dsp.a obj/gyp/libwebp_enc.a obj/gyp/libwebp_utils.a libskia_utils.a libskia_opts.a libskia_opts_ssse3.a libskia_ports.a libskia_sfnt.a -Wl,--end-group -lpng -lz -lgif -lpthread -lfontconfig -ldl -lfreetype` + RESULT_COMPILE = `../../experimental/webtry/safec++ -DSK_GAMMA_SRGB -DSK_GAMMA_APPLY_TO_A8 -DSK_SCALAR_TO_FLOAT_EXCLUDED -DSK_ALLOW_STATIC_GLOBAL_INITIALIZERS=1 -DSK_SUPPORT_GPU=0 -DSK_SUPPORT_OPENCL=0 -DSK_FORCE_DISTANCEFIELD_FONTS=0 -DSK_SCALAR_IS_FLOAT -DSK_CAN_USE_FLOAT -DSK_SAMPLES_FOR_X -DSK_BUILD_FOR_UNIX -DSK_USE_POSIX_THREADS -DSK_SYSTEM_ZLIB=1 -DSK_DEBUG -DSK_DEVELOPER=1 -I../../src/core -I../../src/images -I../../tools/flags -I../../include/config -I../../include/core -I../../include/pathops -I../../include/pipe -I../../include/effects -I../../include/ports -I../../src/sfnt -I../../include/utils -I../../src/utils -I../../include/images -g -fno-exceptions -fstrict-aliasing -Wall -Wextra -Winit-self -Wpointer-arith -Wno-unused-parameter -Wno-c++11-extensions -Werror -m64 -fno-rtti -Wnon-virtual-dtor -c ../../../cache/%s.cpp -o ../../../cache/%s.o` + LINK = `../../experimental/webtry/safec++ -m64 -lstdc++ -lm -o ../../../inout/%s -Wl,--start-group ../../../cache/%s.o obj/experimental/webtry/webtry.main.o obj/gyp/libflags.a libskia_images.a libskia_core.a libskia_effects.a obj/gyp/libjpeg.a obj/gyp/libwebp_dec.a obj/gyp/libwebp_demux.a obj/gyp/libwebp_dsp.a obj/gyp/libwebp_enc.a obj/gyp/libwebp_utils.a libskia_utils.a libskia_opts.a libskia_opts_ssse3.a libskia_ports.a libskia_sfnt.a -Wl,--end-group -lpng -lz -lgif -lpthread -lfontconfig -ldl -lfreetype` DEFAULT_SAMPLE = `SkPaint p; p.setColor(SK_ColorRED); p.setAntiAlias(true);
On 2014/04/30 19:25:52, I haz the power (commit-bot) wrote: > Failed to apply patch for experimental/webtry/webtry.go: > While running patch -p1 --forward --force --no-backup-if-mismatch; > patching file experimental/webtry/webtry.go > Hunk #1 FAILED at 25. > 1 out of 1 hunk FAILED -- saving rejects to file > experimental/webtry/webtry.go.rej > > Patch: experimental/webtry/webtry.go > Index: experimental/webtry/webtry.go > diff --git a/experimental/webtry/webtry.go b/experimental/webtry/webtry.go > index > 79abaf1c1522ef89d2ba98007c0c6f30129af195..e6c76948dcedb66b1e0b285363f8b68de10b23a5 > 100644 > --- a/experimental/webtry/webtry.go > +++ b/experimental/webtry/webtry.go > @@ -25,8 +25,8 @@ import ( > ) > > const ( > - RESULT_COMPILE = `c++ -DSK_GAMMA_SRGB -DSK_GAMMA_APPLY_TO_A8 > -DSK_SCALAR_TO_FLOAT_EXCLUDED -DSK_ALLOW_STATIC_GLOBAL_INITIALIZERS=1 > -DSK_SUPPORT_GPU=0 -DSK_SUPPORT_OPENCL=0 -DSK_FORCE_DISTANCEFIELD_FONTS=0 > -DSK_SCALAR_IS_FLOAT -DSK_CAN_USE_FLOAT -DSK_SAMPLES_FOR_X -DSK_BUILD_FOR_UNIX > -DSK_USE_POSIX_THREADS -DSK_SYSTEM_ZLIB=1 -DSK_DEBUG -DSK_DEVELOPER=1 > -I../../src/core -I../../src/images -I../../tools/flags -I../../include/config > -I../../include/core -I../../include/pathops -I../../include/pipe > -I../../include/effects -I../../include/ports -I../../src/sfnt > -I../../include/utils -I../../src/utils -I../../include/images -g > -fno-exceptions -fstrict-aliasing -Wall -Wextra -Winit-self -Wpointer-arith > -Wno-unused-parameter -Wno-c++11-extensions -Werror -m64 -fno-rtti > -Wnon-virtual-dtor -c ../../../cache/%s.cpp -o ../../../cache/%s.o` > - LINK = `c++ -m64 -lstdc++ -lm -o ../../../inout/%s -Wl,--start-group > ../../../cache/%s.o obj/experimental/webtry/webtry.main.o obj/gyp/libflags.a > libskia_images.a libskia_core.a libskia_effects.a obj/gyp/libjpeg.a > obj/gyp/libwebp_dec.a obj/gyp/libwebp_demux.a obj/gyp/libwebp_dsp.a > obj/gyp/libwebp_enc.a obj/gyp/libwebp_utils.a libskia_utils.a libskia_opts.a > libskia_opts_ssse3.a libskia_ports.a libskia_sfnt.a -Wl,--end-group -lpng -lz > -lgif -lpthread -lfontconfig -ldl -lfreetype` > + RESULT_COMPILE = `../../experimental/webtry/safec++ -DSK_GAMMA_SRGB > -DSK_GAMMA_APPLY_TO_A8 -DSK_SCALAR_TO_FLOAT_EXCLUDED > -DSK_ALLOW_STATIC_GLOBAL_INITIALIZERS=1 -DSK_SUPPORT_GPU=0 -DSK_SUPPORT_OPENCL=0 > -DSK_FORCE_DISTANCEFIELD_FONTS=0 -DSK_SCALAR_IS_FLOAT -DSK_CAN_USE_FLOAT > -DSK_SAMPLES_FOR_X -DSK_BUILD_FOR_UNIX -DSK_USE_POSIX_THREADS -DSK_SYSTEM_ZLIB=1 > -DSK_DEBUG -DSK_DEVELOPER=1 -I../../src/core -I../../src/images > -I../../tools/flags -I../../include/config -I../../include/core > -I../../include/pathops -I../../include/pipe -I../../include/effects > -I../../include/ports -I../../src/sfnt -I../../include/utils -I../../src/utils > -I../../include/images -g -fno-exceptions -fstrict-aliasing -Wall -Wextra > -Winit-self -Wpointer-arith -Wno-unused-parameter -Wno-c++11-extensions -Werror > -m64 -fno-rtti -Wnon-virtual-dtor -c ../../../cache/%s.cpp -o > ../../../cache/%s.o` > + LINK = `../../experimental/webtry/safec++ -m64 -lstdc++ -lm -o > ../../../inout/%s -Wl,--start-group ../../../cache/%s.o > obj/experimental/webtry/webtry.main.o obj/gyp/libflags.a libskia_images.a > libskia_core.a libskia_effects.a obj/gyp/libjpeg.a obj/gyp/libwebp_dec.a > obj/gyp/libwebp_demux.a obj/gyp/libwebp_dsp.a obj/gyp/libwebp_enc.a > obj/gyp/libwebp_utils.a libskia_utils.a libskia_opts.a libskia_opts_ssse3.a > libskia_ports.a libskia_sfnt.a -Wl,--end-group -lpng -lz -lgif -lpthread > -lfontconfig -ldl -lfreetype` > DEFAULT_SAMPLE = `SkPaint p; > p.setColor(SK_ColorRED); > p.setAntiAlias(true); Forgot to rebase, retrying.
The CQ bit was checked by jcgregorio@google.com
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/265453010/50001
Message was sent while issue was closed.
Change committed as 14483 |