Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 265453009: remove inverse_paths from ignored tests (Closed)

Created:
6 years, 7 months ago by caryclark
Modified:
6 years, 7 months ago
Reviewers:
reed
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

remove inverse_paths from ignored tests new expectations have been checked in https://codereview.chromium.org/264653003 TBR=reed NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=14477

Patch Set 1 #

Patch Set 2 : work in progress : cubic/line failure test #

Patch Set 3 : experiment with better cubic line intersection #

Patch Set 4 : update pathop gyp with test #

Patch Set 5 : experiment with 128 bit floats #

Unified diffs Side-by-side diffs Delta from patch set Stats (+638 lines, -8 lines) Patch
M gyp/pathops_unittest.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/pathops/SkDCubicLineIntersection.cpp View 1 2 3 4 1 chunk +13 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsCubic.h View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsCubic.cpp View 1 2 3 4 5 chunks +107 lines, -1 line 0 comments Download
M src/pathops/SkPathOpsDebug.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsTypes.h View 1 2 3 4 2 chunks +11 lines, -3 lines 0 comments Download
M src/pathops/SkPathOpsTypes.cpp View 1 2 3 4 2 chunks +108 lines, -0 lines 0 comments Download
A tests/PathOpsCubicLineIntersectionIdeas.cpp View 1 2 3 4 1 chunk +298 lines, -0 lines 0 comments Download
M tests/PathOpsCubicLineIntersectionTest.cpp View 1 2 3 chunks +34 lines, -1 line 0 comments Download
M tests/PathOpsOpTest.cpp View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
M tools/pathops_sorter.htm View 1 2 3 4 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
caryclark
The CQ bit was checked by caryclark@google.com
6 years, 7 months ago (2014-04-30 16:34:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/265453009/1
6 years, 7 months ago (2014-04-30 16:34:28 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 16:34:47 UTC) #3
Message was sent while issue was closed.
Change committed as 14477

Powered by Google App Engine
This is Rietveld 408576698