Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 265453003: HTML Imports: Let dynamically-added imports sync. (Closed)

Created:
6 years, 7 months ago by Hajime Morrita
Modified:
6 years, 7 months ago
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, adamk+blink_chromium.org
Visibility:
Public.

Description

HTML Imports: Let dynamically-added imports sync. Dynamically added import was marked as async. But it was unspec-ed behavior and should be sync as usual imports. TEST=import-dynamic-async-notblock-sync.html,import-dynamic-block-async.html, improt-dynamic-block-sync.html, import-dynamic-descendant-block.html BUG=367351 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173149

Patch Set 1 #

Patch Set 2 : Landing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -114 lines) Patch
D LayoutTests/fast/html/imports/import-async.html View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/fast/html/imports/import-async-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/html/imports/import-async-shared.html View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/html/imports/import-async-shared-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/html/imports/import-async-tree.html View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/html/imports/import-async-tree-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-dynamic.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/html/imports/import-dynamic-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/html/imports/import-dynamic-shared.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-dynamic-shared-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-dynamic-tree.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-dynamic-tree-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/http/tests/htmlimports/import-dynamic-async-notblock-sync.html View 1 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/htmlimports/import-dynamic-async-notblock-sync-expected.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/htmlimports/import-dynamic-block-async.html View 1 chunk +29 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/htmlimports/import-dynamic-block-async-expected.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/htmlimports/import-dynamic-block-dynamic.html View 1 chunk +32 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/htmlimports/import-dynamic-block-dynamic-expected.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/htmlimports/import-dynamic-block-sync.html View 1 chunk +25 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/htmlimports/import-dynamic-block-sync-expected.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/htmlimports/import-dynamic-descendant-block.html View 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/htmlimports/import-dynamic-descendant-block-expected.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/htmlimports/resources/having-dynamic-child.html View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/html/imports/LinkImport.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Hajime Morrita
Dimitri, could you take a look at this and https://codereview.chromium.org/251813006/ ? These are "import ordering" ...
6 years, 7 months ago (2014-04-30 01:16:30 UTC) #1
dglazkov
lgtm
6 years, 7 months ago (2014-04-30 22:58:02 UTC) #2
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 7 months ago (2014-05-01 22:24:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/265453003/20001
6 years, 7 months ago (2014-05-01 22:25:45 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 22:53:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink
6 years, 7 months ago (2014-05-01 22:53:26 UTC) #6
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 7 months ago (2014-05-01 23:09:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/265453003/20001
6 years, 7 months ago (2014-05-01 23:09:56 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 23:49:55 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink
6 years, 7 months ago (2014-05-01 23:49:55 UTC) #10
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 7 months ago (2014-05-02 00:36:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/265453003/20001
6 years, 7 months ago (2014-05-02 00:36:25 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 01:12:14 UTC) #13
Message was sent while issue was closed. 
Change committed as 173149

Powered by Google App Engine
This is Rietveld 408576698