Issue 2654443003: Revert "VM: Fix memory leaks during isolate spawning"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2654443003: Revert "VM: Fix memory leaks during isolate spawning" (Closed)

Created:
3 years, 11 months ago by kustermann

Modified:
3 years, 11 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "VM: Fix memory leaks during isolate spawning" This reverts commit d7e884b05f762f8d5016eb8a5444471b647e213a. Committed: https://github.com/dart-lang/sdk/commit/50150deaf622b4950efc39680065fc860e4e442d

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -93 lines)			Patch
M	runtime/lib/isolate.cc	View	3 chunks	+12 lines, -40 lines	0 comments	Download
M	runtime/vm/datastream.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/isolate.h	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	4 chunks	+11 lines, -8 lines	0 comments	Download
M	runtime/vm/snapshot.h	View	2 chunks	+2 lines, -33 lines	0 comments	Download
M	runtime/vm/snapshot.cc	View	3 chunks	+2 lines, -7 lines	0 comments	Download
M	tests/isolate/isolate.status	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 4 (2 generated)

kustermann

3 years, 11 months ago (2017-01-24 09:33:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
50150deaf622b4950efc39680065fc860e4e442d (presubmit successful).