Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: ios/chrome/browser/find_in_page/find_in_page_controller.mm

Issue 2654433007: [ios] Moves find-in-page code out of Tab and into FindTabHelper. (Closed)
Patch Set: Review. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/find_in_page/BUILD.gn ('k') | ios/chrome/browser/find_in_page/find_tab_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/find_in_page/find_in_page_controller.mm
diff --git a/ios/chrome/browser/find_in_page/find_in_page_controller.mm b/ios/chrome/browser/find_in_page/find_in_page_controller.mm
index 75dd3cf15ce809a56799a4f545bdb081f1f33bf5..dbb5c17467635a46c641b3bf11f7015097c83810 100644
--- a/ios/chrome/browser/find_in_page/find_in_page_controller.mm
+++ b/ios/chrome/browser/find_in_page/find_in_page_controller.mm
@@ -39,7 +39,7 @@ static NSString* gSearchTerm;
}
@interface FindInPageController () <DOMAltering, CRWWebStateObserver>
-// The find in page controller delegate.
+// The find in page controller delegate. Can be nil.
@property(nonatomic, readonly) id<FindInPageControllerDelegate> delegate;
// The web view's scroll view.
@@ -103,7 +103,6 @@ static NSString* gSearchTerm;
delegate:(id<FindInPageControllerDelegate>)delegate {
self = [super init];
if (self) {
- DCHECK(delegate);
_findInPageJsManager = base::mac::ObjCCastStrict<JsFindinpageManager>(
[webState->GetJSInjectionReceiver()
instanceOfClass:[JsFindinpageManager class]]);
« no previous file with comments | « ios/chrome/browser/find_in_page/BUILD.gn ('k') | ios/chrome/browser/find_in_page/find_tab_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698