Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: ios/chrome/browser/find_in_page/find_tab_helper_unittest.mm

Issue 2654433007: [ios] Moves find-in-page code out of Tab and into FindTabHelper. (Closed)
Patch Set: Fix tests. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #import "ios/chrome/browser/find_in_page/find_tab_helper.h"
6
7 #include "base/macros.h"
8 #import "ios/web/public/test/fakes/test_web_state.h"
9 #import "ios/web/public/test/web_test.h"
10
11 #if !defined(__has_feature) || !__has_feature(objc_arc)
12 #error "This file requires ARC support."
13 #endif
14
15 // Test fixture for the FindTabHelper class.
16 class FindTabHelperTest : public web::WebTest {
17 public:
18 FindTabHelperTest() { FindTabHelper::CreateForWebState(&web_state_, nil); }
19 ~FindTabHelperTest() override = default;
20
21 protected:
22 web::TestWebState web_state_;
23
24 private:
25 DISALLOW_COPY_AND_ASSIGN(FindTabHelperTest);
Eugene But (OOO till 7-30) 2017/02/10 00:03:36 nit: Do we need this?
rohitrao (ping after 24h) 2017/02/10 13:52:18 I've always included it in every class, unless I e
Eugene But (OOO till 7-30) 2017/02/10 18:31:19 I can't recall any tests which have this macro. I
26 };
27
28 // Tests that the helper's FindInPageController exists.
29 TEST_F(FindTabHelperTest, ControllerExists) {
30 DCHECK(FindTabHelper::FromWebState(&web_state_)->GetController());
31 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698