Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 // Copyright 2017 The Chromium Authors. All rights reserved. | |
| 2 // Use of this source code is governed by a BSD-style license that can be | |
| 3 // found in the LICENSE file. | |
| 4 | |
| 5 #ifndef IOS_CHROME_BROWSER_FIND_IN_PAGE_FIND_TAB_HELPER_H_ | |
| 6 #define IOS_CHROME_BROWSER_FIND_IN_PAGE_FIND_TAB_HELPER_H_ | |
| 7 | |
| 8 #include "base/macros.h" | |
| 9 #import "ios/web/public/web_state/web_state_observer.h" | |
|
Eugene But (OOO till 7-30)
2017/01/31 19:03:48
nit: s/import/include
rohitrao (ping after 24h)
2017/02/08 16:14:59
Done.
| |
| 10 #import "ios/web/public/web_state/web_state_user_data.h" | |
| 11 | |
| 12 @class FindInPageController; | |
| 13 @protocol FindInPageControllerDelegate; | |
| 14 | |
| 15 // Adds support for the "Find in page" feature. | |
| 16 class FindTabHelper : public web::WebStateObserver, | |
|
Eugene But (OOO till 7-30)
2017/01/31 19:03:48
Should this be FindInPageTabHelper to keep consist
rohitrao (ping after 24h)
2017/02/08 16:14:59
I kept it consistent with desktop.
| |
| 17 public web::WebStateUserData<FindTabHelper> { | |
| 18 public: | |
| 19 static void CreateForWebState( | |
|
Eugene But (OOO till 7-30)
2017/01/31 19:03:48
Could you please add comments. F.e. is it ok to pa
rohitrao (ping after 24h)
2017/02/08 16:14:59
It is now =)
| |
| 20 web::WebState* web_state, | |
| 21 id<FindInPageControllerDelegate> controller_delegate); | |
| 22 | |
| 23 FindTabHelper(web::WebState* web_state, | |
|
Eugene But (OOO till 7-30)
2017/01/31 19:03:48
Should constructor, destructor and NavigationItemC
rohitrao (ping after 24h)
2017/02/08 16:14:59
Done.
| |
| 24 id<FindInPageControllerDelegate> controller_delegate); | |
| 25 ~FindTabHelper() override; | |
| 26 | |
| 27 FindInPageController* GetController(); | |
| 28 | |
| 29 // web::WebStateObserver. | |
| 30 void NavigationItemCommitted( | |
| 31 const web::LoadCommittedDetails& load_details) override; | |
| 32 | |
| 33 private: | |
| 34 // The WebState that this object is attached to. | |
| 35 web::WebState* web_state_; | |
| 36 | |
| 37 FindInPageController* controller_; | |
| 38 | |
| 39 DISALLOW_COPY_AND_ASSIGN(FindTabHelper); | |
| 40 }; | |
| 41 | |
| 42 #endif // IOS_CHROME_BROWSER_FIND_IN_PAGE_FIND_TAB_HELPER_H_ | |
| OLD | NEW |