Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: runtime/vm/intermediate_language_arm.cc

Issue 265443002: VM: Explicitly load function and context before calling a closure. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_arm.cc
===================================================================
--- runtime/vm/intermediate_language_arm.cc (revision 35546)
+++ runtime/vm/intermediate_language_arm.cc (working copy)
@@ -182,29 +182,27 @@
LocationSummary* ClosureCallInstr::MakeLocationSummary(bool opt) const {
- return MakeCallSummary();
+ const intptr_t kNumInputs = 1;
+ const intptr_t kNumTemps = 0;
+ LocationSummary* summary =
+ new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kCall);
+ summary->set_in(0, Location::RegisterLocation(R0)); // Function.
+ summary->set_out(0, Location::RegisterLocation(R0));
+ return summary;
}
void ClosureCallInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
- // Load closure object (first argument) in R1.
- int argument_count = ArgumentCount();
- __ ldr(R1, Address(SP, (argument_count - 1) * kWordSize));
-
// Load arguments descriptor in R4.
+ int argument_count = ArgumentCount();
const Array& arguments_descriptor =
Array::ZoneHandle(ArgumentsDescriptor::New(argument_count,
argument_names()));
__ LoadObject(R4, arguments_descriptor);
- // Load the closure function into R0.
- __ ldr(R0, FieldAddress(R1, Closure::function_offset()));
-
- // Load closure context in CTX; note that CTX has already been preserved.
- __ ldr(CTX, FieldAddress(R1, Closure::context_offset()));
-
// R4: Arguments descriptor.
// R0: Function.
+ ASSERT(locs()->in(0).reg() == R0);
__ ldr(R2, FieldAddress(R0, Function::code_offset()));
// R2: code.
@@ -221,7 +219,7 @@
// deoptimization point in optimized code, after call.
const intptr_t deopt_id_after = Isolate::ToDeoptAfter(deopt_id());
if (compiler->is_optimizing()) {
- compiler->AddDeoptIndexAtCall(deopt_id_after, token_pos());
+ compiler->AddDeoptIndexAtCall(deopt_id_after, token_pos(), InputCount());
} else {
// Add deoptimization continuation point after the call and before the
// arguments are removed.
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698