Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: runtime/vm/intermediate_language.h

Issue 265443002: VM: Explicitly load function and context before calling a closure. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/il_printer.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.h
===================================================================
--- runtime/vm/intermediate_language.h (revision 35546)
+++ runtime/vm/intermediate_language.h (working copy)
@@ -2850,12 +2850,15 @@
};
-class ClosureCallInstr : public TemplateDefinition<0> {
+class ClosureCallInstr : public TemplateDefinition<1> {
public:
- ClosureCallInstr(ClosureCallNode* node,
+ ClosureCallInstr(Value* function,
+ ClosureCallNode* node,
ZoneGrowableArray<PushArgumentInstr*>* arguments)
: ast_node_(*node),
- arguments_(arguments) { }
+ arguments_(arguments) {
+ SetInputAt(0, function);
+ }
DECLARE_INSTRUCTION(ClosureCall)
@@ -7800,6 +7803,11 @@
void PrintTo(BufferFormatter* f) const;
const char* ToCString() const;
+ // Deep copy an environment. The 'length' parameter may be less than the
+ // environment's length in order to drop values (e.g., passed arguments)
+ // from the copy.
+ Environment* DeepCopy(intptr_t length) const;
+
private:
friend class ShallowIterator;
@@ -7815,10 +7823,6 @@
code_(code),
outer_(outer) { }
- // Deep copy an environment. The 'length' parameter may be less than the
- // environment's length in order to drop values (e.g., passed arguments)
- // from the copy.
- Environment* DeepCopy(intptr_t length) const;
GrowableArray<Value*> values_;
Location* locations_;
« no previous file with comments | « runtime/vm/il_printer.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698