Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1821)

Unified Diff: chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.h

Issue 2654413002: Stretching NativeViewHost, and misc tab capture fixes.
Patch Set: Gettin' it all working on ui/cocoa and MacViews too. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.h
diff --git a/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.h b/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.h
index 3801260fb778328118e3e4ce4484f882f213eabc..2d4348ace9d686e65daf9b4dfd15ac873f33fc83 100644
--- a/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.h
+++ b/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.h
@@ -27,9 +27,16 @@ class WebContents;
// AutoEmbedFullscreen mode: When enabled, TabContentsController will observe
// for WebContents fullscreen changes and automatically swap the normal
// WebContents view with the fullscreen view (if different). In addition, if a
-// WebContents is being screen-captured, the view will be centered within the
-// container view, sized to the aspect ratio of the capture video resolution,
-// and scaling will be avoided whenever possible.
+// WebContents is being screen-captured, the WebContentsView will be centered
+// within the container view and sized to the aspect ratio of the capture video
+// resolution; also, the WebContentsView will be sized so that the page is
+// rendered at the capture video resolution. This means the container view can
+// have a different size than the WebContentsView, and the tab content may
+// appear scaled within the browser window on the local screen. The reason for
+// doing all this is to improve quality and performance: For example, pages that
+// stream video content will dynamically adapt their video playback resolution
+// based on their rendering size; and so this should ideally match the tab
+// capture size.
@interface TabContentsController : NSViewController {
@private
content::WebContents* contents_; // weak

Powered by Google App Engine
This is Rietveld 408576698