third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-garbage-collection-ran-during-success.html - Issue 2654403002: Implement WebBluetooth descriptor.writeValue()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-garbage-collection-ran-during-success.html

Issue 2654403002: Implement WebBluetooth descriptor.writeValue() (Closed)

Patch Set: #4 Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-garbage-collection-ran-during-error.html ('k') | third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-reconnect-during-error.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-garbage-collection-ran-during-success.html

diff --git a/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-garbage-collection-ran-during-success.html b/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-garbage-collection-ran-during-success.html

similarity index 90%

copy from third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-garbage-collection-ran-during-success.html

copy to third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-garbage-collection-ran-during-success.html

index 42dbf74e38063e3630eaea0f6b9a247a4e1d4fef..2b525fc6c797dbaf5b4a8073096beca2b887acd4 100644

--- a/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-garbage-collection-ran-during-success.html

+++ b/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-garbage-collection-ran-during-success.html

@@ -7,6 +7,7 @@

'use strict';

promise_test(

() => {

+ let val = new Uint8Array([1]);

let promise;

return setBluetoothFakeAdapter('DisconnectingHealthThermometerAdapter')

.then(

@@ -21,7 +22,7 @@ promise_test(

characteristic.getDescriptor(user_description.name))

.then(descriptor => {

promise = assert_promise_rejects_with_message(

- descriptor.readValue(),

+ descriptor.writeValue(val),

new DOMException(

'GATT Server disconnected while performing a GATT operation.',

'NetworkError'));

@@ -32,7 +33,7 @@ promise_test(

.then(runGarbageCollection)

.then(() => promise);

- 'Garbage collection ran during a readValue call that succeeds. ' +

+ 'Garbage collection ran during a writeValue call that succeeds. ' +

'Should not crash.');

</script>