Issue 265433002: Revert 266968 "NonSFI NaCl: Plumb Exception IRT enough for break..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 265433002: Revert 266968 "NonSFI NaCl: Plumb Exception IRT enough for break..." (Closed)

Created:
6 years, 7 months ago by awong

Modified:
6 years, 7 months ago

Reviewers:
Junichi Uekawa

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 266968 "NonSFI NaCl: Plumb Exception IRT enough for break..." Compile failure in ChromiumOS (daisy) builder. "irt_exception_handling.cc:101:15: error: 'LOG_FATAL' was not declared in this scope." > NonSFI NaCl: Plumb Exception IRT enough for breakpad. > > Implements irt_exception. > > This is enough to get breakpad start reporting minidumps on crash. > > Stack overflow case handling with sigaltstack will be handled in a followup change. > > BUG=356925 > NOTRY=True > > Review URL: https://codereview.chromium.org/230413002 TBR=uekawa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266987

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -337 lines)			Patch
D	trunk/src/chrome/test/data/nacl/irt_exception/irt_exception_test.cc	View	1 chunk	+0 lines, -46 lines	0 comments	Download
D	trunk/src/chrome/test/data/nacl/irt_exception/irt_exception_test.html	View	1 chunk	+0 lines, -55 lines	0 comments	Download
D	trunk/src/chrome/test/data/nacl/irt_exception/irt_exception_test.nmf	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	trunk/src/chrome/test/data/nacl/nacl_test_data.gyp	View	1 chunk	+0 lines, -66 lines	0 comments	Download
M	trunk/src/chrome/test/nacl/nacl_browsertest.cc	View	1 chunk	+0 lines, -16 lines	0 comments	Download
M	trunk/src/chrome/test/nacl/nacl_browsertest_util.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	trunk/src/chrome/test/nacl/nacl_browsertest_util.cc	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	trunk/src/components/nacl.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/components/nacl/loader/nacl_helper_linux.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	trunk/src/components/nacl/loader/nonsfi/DEPS	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	trunk/src/components/nacl/loader/nonsfi/irt_exception_handling.h	View	1 chunk	+0 lines, -16 lines	0 comments	Download
D	trunk/src/components/nacl/loader/nonsfi/irt_exception_handling.cc	View	1 chunk	+0 lines, -106 lines	0 comments	Download
M	trunk/src/components/nacl/loader/nonsfi/irt_interfaces.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/components/nacl/loader/nonsfi/irt_interfaces.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r266987.

Expand Messages | Collapse Messages