Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2654303003: Ignore files that are hidden by generated files. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ignore files that are hidden by generated files. We cannot analyze them - their URIs will be resolved to other files, element models will not correspond to ASTs, etc. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f28e8afb23b20193b8cc47136b793a2f3a721900

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -50 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 6 chunks +40 lines, -26 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/file_state.dart View 3 chunks +26 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/analysis/base.dart View 5 chunks +7 lines, -0 lines 1 comment Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 3 chunks +58 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/file_state_test.dart View 2 chunks +16 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
scheglov
3 years, 11 months ago (2017-01-26 22:27:48 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2654303003/diff/1/pkg/analyzer/test/src/dart/analysis/base.dart File pkg/analyzer/test/src/dart/analysis/base.dart (right): https://codereview.chromium.org/2654303003/diff/1/pkg/analyzer/test/src/dart/analysis/base.dart#newcode20 pkg/analyzer/test/src/dart/analysis/base.dart:20: import 'package:typed_mock/typed_mock.dart'; Sort?
3 years, 11 months ago (2017-01-26 22:32:42 UTC) #3
Paul Berry
lgtm
3 years, 10 months ago (2017-01-27 13:04:42 UTC) #4
scheglov
3 years, 10 months ago (2017-01-27 16:47:50 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
f28e8afb23b20193b8cc47136b793a2f3a721900 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698