Always call StorageMonitor::RemoveObserver in ~MediaFileSystemRegistry.

chrome/browser/media_galleries/gallery_watch_manager_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media_galleries/gallery_watch_manager.h"
 
 #include <memory>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "base/test/scoped_path_override.h"
 #include "build/build_config.h"
 #include "chrome/browser/extensions/test_extension_system.h"
 #include "chrome/browser/media_galleries/gallery_watch_manager_observer.h"
 #include "chrome/browser/media_galleries/media_galleries_preferences.h"
 #include "chrome/browser/media_galleries/media_galleries_preferences_factory.h"
 #include "chrome/browser/media_galleries/media_galleries_test_util.h"
+#include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/storage_monitor/test_storage_monitor.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/permissions/media_galleries_permission.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/login/users/scoped_test_user_manager.h"
@@ skipping 55 matching lines @@
 
     manager_.reset(new GalleryWatchManager);
     manager_->AddObserver(profile_.get(), this);
   }
 
   void TearDown() override {
     if (profile_) {
       manager_->RemoveObserver(profile_.get());
     }
     manager_.reset();
+
+    // The TestingProfile must be destroyed before the TestingBrowserProcess
+    // because it uses it in its destructor.
+    ShutdownProfile();
+
+    // The MediaFileSystemRegistry owned by the TestingBrowserProcess must be
+    // destroyed before the StorageMonitor because it calls
+    // StorageMonitor::RemoveObserver() in its destructor.
+    TestingBrowserProcess::DeleteInstance();
+
     storage_monitor::TestStorageMonitor::Destroy();
   }
 
  protected:
   // Create the specified path, and add it to preferences as a gallery.
   MediaGalleryPrefId AddGallery(const base::FilePath& path) {
     MediaGalleryPrefInfo gallery_info;
     EXPECT_FALSE(gallery_prefs_->LookUpGalleryByPath(path, &gallery_info));
     MediaGalleryPrefId id =
         gallery_prefs_->AddGallery(gallery_info.device_id,
@@ skipping 291 matching lines @@
   ShutdownProfile();
 
   // Trigger a removable storage event that should be ignored now that the
   // profile has been destroyed to catch regressions. crbug.com/467627
   base::RunLoop run_loop;
   storage_monitor()->receiver()->ProcessDetach(storage_info.device_id());
   run_loop.RunUntilIdle();
 }
 
 }  // namespace component_updater