Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2654293002: Extract reusable parts of _CompilerCommonElements in a CommonElementsMixin (Closed)

Created:
3 years, 11 months ago by Johnni Winther
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extract reusable parts of _CompilerCommonElements in a CommonElementsMixin R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/c84808cc83c9b408102b50062d0517ed85b5802b

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -298 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 6 chunks +56 lines, -298 lines 0 comments Download
M pkg/compiler/lib/src/core_types.dart View 1 2 chunks +261 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 11 months ago (2017-01-26 16:04:07 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 11 months ago (2017-01-26 20:38:56 UTC) #3
Johnni Winther
3 years, 11 months ago (2017-01-27 08:20:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c84808cc83c9b408102b50062d0517ed85b5802b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698