Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/foozzie/v8_mock.js

Issue 2654273004: [foozzie] Improve mocking stack traces (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/foozzie/v8_mock.js
diff --git a/tools/foozzie/v8_mock.js b/tools/foozzie/v8_mock.js
index 4bd3ce54025988eb647ceb60a135453e3f1f92e3..3cb19ddc8f9c32cc9254854c97a5a6be3205f3b3 100644
--- a/tools/foozzie/v8_mock.js
+++ b/tools/foozzie/v8_mock.js
@@ -55,7 +55,7 @@ var __PrettyPrint = function __PrettyPrint(msg) { print(msg); };
Error.prepareStackTrace = function (error, structuredStackTrace) {
return "";
};
-Object.freeze(Error)
+Object.defineProperty(Error, 'prepareStackTrace', { writable: false });
Yang 2017/01/27 08:43:38 if you dont make it non configurable you can still
Michael Achenbach 2017/01/27 08:46:41 Argh! Done...
// Mock buffer access in float typed arrays because of varying NaN patterns.
// Note, for now we just use noop forwarding proxies, because they already
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698