Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2654273002: Improve precision of stacktrace_test (Closed)

Created:
3 years, 11 months ago by Johnni Winther
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -11 lines) Patch
M tests/compiler/dart2js/sourcemaps/stacktrace_test.dart View 1 11 chunks +94 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Johnni Winther
3 years, 11 months ago (2017-01-26 13:37:21 UTC) #3
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2654273002/diff/1/tests/compiler/dart2js/sourcemaps/stacktrace_test.dart File tests/compiler/dart2js/sourcemaps/stacktrace_test.dart (right): https://codereview.chromium.org/2654273002/diff/1/tests/compiler/dart2js/sourcemaps/stacktrace_test.dart#newcode296 tests/compiler/dart2js/sourcemaps/stacktrace_test.dart:296: new SingleMapping.fromJson(JSON.decode(sourceMapText)); nit: you should be able to ...
3 years, 11 months ago (2017-01-26 19:22:18 UTC) #4
Johnni Winther
https://codereview.chromium.org/2654273002/diff/1/tests/compiler/dart2js/sourcemaps/stacktrace_test.dart File tests/compiler/dart2js/sourcemaps/stacktrace_test.dart (right): https://codereview.chromium.org/2654273002/diff/1/tests/compiler/dart2js/sourcemaps/stacktrace_test.dart#newcode296 tests/compiler/dart2js/sourcemaps/stacktrace_test.dart:296: new SingleMapping.fromJson(JSON.decode(sourceMapText)); On 2017/01/26 19:22:18, Siggi Cherem (dart-lang) wrote: ...
3 years, 11 months ago (2017-01-27 08:08:14 UTC) #5
Johnni Winther
3 years, 11 months ago (2017-01-27 08:15:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ec71517bc8b16ea946a1d8c3ae136677c60b8262 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698