Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4044)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeaderViewHolder.java

Issue 2654193002: [Android History] List item shadows and width constrained styling (Closed)
Patch Set: Changes from dgn@ and dfalcantara@ reviews Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeaderViewHolder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeaderViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeaderViewHolder.java
index f78cce57a4f0c105ffb988b164ee7e95fcd31b20..4fe489e20fe8d5cb5df70eef7c240d1eae071b98 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeaderViewHolder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeaderViewHolder.java
@@ -8,11 +8,11 @@ import android.view.LayoutInflater;
import android.widget.TextView;
import org.chromium.chrome.R;
-import org.chromium.chrome.browser.ntp.UiConfig;
-import org.chromium.chrome.browser.ntp.cards.MarginResizer;
import org.chromium.chrome.browser.ntp.cards.NewTabPageRecyclerView;
import org.chromium.chrome.browser.ntp.cards.NewTabPageViewHolder;
import org.chromium.chrome.browser.util.MathUtils;
+import org.chromium.chrome.browser.widget.displaystyle.MarginResizer;
+import org.chromium.chrome.browser.widget.displaystyle.UiConfig;
/**
* View holder for the header of a section of cards.
@@ -29,7 +29,11 @@ public class SectionHeaderViewHolder extends NewTabPageViewHolder {
.inflate(R.layout.new_tab_page_snippets_header, recyclerView, false));
mMaxSnippetHeaderHeight = itemView.getResources().getDimensionPixelSize(
R.dimen.snippets_article_header_height);
- MarginResizer.createWithViewAdapter(itemView, config);
+
+ int wideLateralMargin = recyclerView.getResources().getDimensionPixelSize(
+ R.dimen.ntp_wide_card_lateral_margins);
+ MarginResizer.createWithViewAdapter(itemView, config, 0,
+ wideLateralMargin);
}
public void onBindViewHolder(SectionHeader header) {

Powered by Google App Engine
This is Rietveld 408576698