Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: chrome/android/java/res/values-v17/styles.xml

Issue 2654193002: [Android History] List item shadows and width constrained styling (Closed)
Patch Set: Changes from dgn@ and dfalcantara@ reviews Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <resources xmlns:tools="http://schemas.android.com/tools"> 6 <resources xmlns:tools="http://schemas.android.com/tools">
7 <!-- Q: Why put style resources under values-v17/ ? 7 <!-- Q: Why put style resources under values-v17/ ?
8 A: Problem: 8 A: Problem:
9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339. 9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339.
10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert 10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert
(...skipping 558 matching lines...) Expand 10 before | Expand all | Expand 10 after
569 <item name="android:layout_height">wrap_content</item> 569 <item name="android:layout_height">wrap_content</item>
570 <item name="android:layout_gravity">center_vertical</item> 570 <item name="android:layout_gravity">center_vertical</item>
571 <item name="android:singleLine">true</item> 571 <item name="android:singleLine">true</item>
572 <item name="android:textColor">@android:color/white</item> 572 <item name="android:textColor">@android:color/white</item>
573 <item name="android:textSize">20sp</item> 573 <item name="android:textSize">20sp</item>
574 </style> 574 </style>
575 <style name="PrivacyDisclaimerText"> 575 <style name="PrivacyDisclaimerText">
576 <item name="android:layout_width">match_parent</item> 576 <item name="android:layout_width">match_parent</item>
577 <item name="android:layout_height">wrap_content</item> 577 <item name="android:layout_height">wrap_content</item>
578 <item name="android:layout_marginTop">16dp</item> 578 <item name="android:layout_marginTop">16dp</item>
579 <item name="android:paddingStart">16dp</item>
580 <item name="android:paddingEnd">16dp</item>
581 <item name="android:textSize">16sp</item> 579 <item name="android:textSize">16sp</item>
582 <item name="android:visibility">gone</item> 580 <item name="android:visibility">gone</item>
583 </style> 581 </style>
584 582
585 <!-- New tab page RecyclerView overscroll color --> 583 <!-- New tab page RecyclerView overscroll color -->
586 <style name="NewTabPageRecyclerView"> 584 <style name="NewTabPageRecyclerView">
587 <item name="android:colorEdgeEffect">@color/google_grey_300</item> 585 <item name="android:colorEdgeEffect">@color/google_grey_300</item>
588 </style> 586 </style>
589 587
590 <!-- History UI --> 588 <!-- History UI -->
591 <style name="HistoryStartIcon"> 589 <style name="HistoryStartIcon">
592 <item name="android:layout_width">@dimen/selectable_list_layout_start_ic on_width</item> 590 <item name="android:layout_width">@dimen/selectable_list_layout_start_ic on_width</item>
593 <item name="android:layout_height">match_parent</item> 591 <item name="android:layout_height">match_parent</item>
594 <item name="android:scaleType">center</item> 592 <item name="android:scaleType">center</item>
595 </style> 593 </style>
596 <style name="HistoryEndIcon"> 594 <style name="HistoryEndIcon">
597 <item name="android:layout_width">wrap_content</item> 595 <item name="android:layout_width">wrap_content</item>
598 <item name="android:layout_height">match_parent</item> 596 <item name="android:layout_height">match_parent</item>
599 <item name="android:paddingStart">16dp</item> 597 <item name="android:paddingStart">16dp</item>
600 <item name="android:paddingEnd">16dp</item>
601 <item name="android:background">@null</item> 598 <item name="android:background">@null</item>
602 <item name="android:scaleType">center</item> 599 <item name="android:scaleType">center</item>
600 <item name="android:paddingEnd">@dimen/selectable_list_layout_row_end_pa dding</item>
603 </style> 601 </style>
604 602
605 <!-- Download Home --> 603 <!-- Download Home -->
606 <style name="DownloadHomeStatusText"> 604 <style name="DownloadHomeStatusText">
607 <item name="android:layout_width">wrap_content</item> 605 <item name="android:layout_width">wrap_content</item>
608 <item name="android:layout_height">wrap_content</item> 606 <item name="android:layout_height">wrap_content</item>
609 <item name="android:layout_marginTop">0dp</item> 607 <item name="android:layout_marginTop">0dp</item>
610 <item name="android:minHeight">18dp</item> 608 <item name="android:minHeight">18dp</item>
611 <item name="android:textColor">@color/google_grey_600</item> 609 <item name="android:textColor">@color/google_grey_600</item>
612 <item name="android:textSize">12sp</item>1 610 <item name="android:textSize">12sp</item>1
613 <item name="android:ellipsize">start</item> 611 <item name="android:ellipsize">start</item>
614 <item name="android:singleLine">true</item> 612 <item name="android:singleLine">true</item>
615 </style> 613 </style>
616 </resources> 614 </resources>
OLDNEW
« no previous file with comments | « chrome/android/java/res/layout/search_toolbar.xml ('k') | chrome/android/java/res/values/dimens.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698