chrome/android/java/res/layout/history_date_view.xml - Issue 2654193002: [Android History] List item shadows and width constrained styling

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/history_date_view.xml

Issue 2654193002: [Android History] List item shadows and width constrained styling (Closed)

Patch Set: Fix some styling for supervised users Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <!-- TODO(twellington): merge with regular date_view.xml once UIs are unified. - ->

	7 <TextView xmlns:android="http://schemas.android.com/apk/res/android"

	8 style="@style/RobotoMediumStyle"

	9 android:layout_width="match_parent"

	10 android:layout_height="wrap_content"

	11 android:layout_marginBottom="15dp"
	gone 2017/01/27 18:48:52 Little strange to have these be 15 and 17 instead Little strange to have these be 15 and 17 instead of 16 and 16. Is it intentionally off-center? Theresa 2017/01/27 23:34:45 Yes, it is intentionally off center. The date view Show quoted text On 2017/01/27 18:48:52, dfalcantara (load balance plz) wrote: > Little strange to have these be 15 and 17 instead of 16 and 16. Is it > intentionally off-center? Yes, it is intentionally off center. The date view should be closer to the history items it's associated with than the history items above it.
	12 android:layout_marginTop="17dp"

	13 android:textSize="16sp" />

OLD	NEW