harmony: partly harmonize permissions bubble

chrome/browser/ui/views/harmony/harmony_layout_delegate.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/harmony/harmony_layout_delegate.h"
 
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 
 static base::LazyInstance<HarmonyLayoutDelegate> harmony_layout_delegate_ =
@@ skipping 19 matching lines @@
     case LayoutDistanceType::UNRELATED_CONTROL_VERTICAL_SPACING:
       return kHarmonyLayoutUnit;
     case LayoutDistanceType::UNRELATED_CONTROL_LARGE_VERTICAL_SPACING:
       return kHarmonyLayoutUnit;
     case LayoutDistanceType::BUTTON_VEDGE_MARGIN_NEW:
       return kHarmonyLayoutUnit;
     case LayoutDistanceType::BUTTON_HEDGE_MARGIN_NEW:
       return kHarmonyLayoutUnit;
     case LayoutDistanceType::CHECKBOX_INDENT:
       return 0;
+    case LayoutDistanceType::ITEM_LABEL_SPACING:
+      return kHarmonyLayoutUnit / 2;

[Peter Kasting, 2017/01/26 21:54:29]

Shouldn't this be 16 px and not 8?

I'm looking at
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20browser%20(...
, maybe I'm looking at the wrong spec or misunderstanding how this is used.

[Elly Fong-Jones, 2017/01/30 19:47:34]

Oh, yes, you are correct - this ought to have been 16px.

   }
   NOTREACHED();
   return 0;
 }
 
 views::GridLayout::Alignment
 HarmonyLayoutDelegate::GetControlLabelGridAlignment() const {
   return views::GridLayout::LEADING;
 }
 
@@ skipping 10 matching lines @@
     case DialogWidthType::SMALL:
       return 320;
     case DialogWidthType::MEDIUM:
       return 448;
     case DialogWidthType::LARGE:
       return 512;
   }
   NOTREACHED();
   return 0;
 }