Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: chrome/browser/extensions/api/browsing_data/browsing_data_api.h

Issue 2654113003: Move rest of param validation in browsing_data_api.cc to ::RunAsync. (Closed)
Patch Set: sync Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/browsing_data/browsing_data_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/browsing_data/browsing_data_api.h
diff --git a/chrome/browser/extensions/api/browsing_data/browsing_data_api.h b/chrome/browser/extensions/api/browsing_data/browsing_data_api.h
index 0b6f231af24b6be6d0573db3e84e7af19e8300d2..8ffab0f25df8fa83f747f9f5e7fa4554bc09cdfa 100644
--- a/chrome/browser/extensions/api/browsing_data/browsing_data_api.h
+++ b/chrome/browser/extensions/api/browsing_data/browsing_data_api.h
@@ -110,9 +110,11 @@ class BrowsingDataRemoverFunction : public ChromeAsyncExtensionFunction,
void CheckRemovingPluginDataSupported(
scoped_refptr<PluginPrefs> plugin_prefs);
- // Parse the developer-provided |origin_types| object into an origin_type_mask
+ // Parse the developer-provided |origin_types| object into |origin_type_mask|
// that can be used with the BrowsingDataRemover.
- int ParseOriginTypeMask(const base::DictionaryValue& options);
+ // Returns true if parsing was successful.
+ bool ParseOriginTypeMask(const base::DictionaryValue& options,
+ int* origin_type_mask);
// Called when we're ready to start removing data.
void StartRemoving();
« no previous file with comments | « no previous file | chrome/browser/extensions/api/browsing_data/browsing_data_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698