ozone: Allow building for ozone without depending on pango

ozone: Allow building for ozone without depending on pango

Notable changes in this CL:
 * Rename files that depend on pango to have _pango suffix.
 * Add a filename gyp rule to exclude _pango* files when use_pango = 0
 * Add empty implementations for a few font-related API for ozone.

BUG=313793
R=jam@chromium.org, msw@chromium.org, rjkroege@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233228

[sadrul, 2013-11-04 18:51:56]

msw@ for ui/gfx/

dmichael@ for renderer_host/pepper/

jam@ for the rest of content/

rjkroege@ FYI

[sadrul, 2013-11-04 19:04:12]

Add the reviewers for realz this time:

+dmichael@ for renderer_host/pepper/

+jam@ for the rest of content/

+rjkroege@ FYI

[rjkroege, 2013-11-04 23:03:29]

ozone changes lgtm and one random nit.

something weird is going on with the unchanged files?

https://codereview.chromium.org/26541007/diff/3001/content/browser/renderer_h...
File content/browser/renderer_host/pepper/pepper_truetype_font_list_pango.cc
(right):

https://codereview.chromium.org/26541007/diff/3001/content/browser/renderer_h...
content/browser/renderer_host/pepper/pepper_truetype_font_list_pango.cc:56:
fonts_in_family->push_back(desc);
there is no diff shown in this file and yet it's included? maybe you need to
rebase? or the software is confused?

https://codereview.chromium.org/26541007/diff/3001/content/common/font_list.cc
File content/common/font_list.cc (right):

https://codereview.chromium.org/26541007/diff/3001/content/common/font_list.c...
content/common/font_list.cc:9: 
nit: unnecessary?

[msw, 2013-11-04 23:10:46]

https://codereview.chromium.org/26541007/diff/3001/ui/gfx/font_unittest.cc
File ui/gfx/font_unittest.cc (right):

https://codereview.chromium.org/26541007/diff/3001/ui/gfx/font_unittest.cc#ne...
ui/gfx/font_unittest.cc:11: #if defined(OS_POSIX) && !defined(OS_MACOSX) &&
!defined(OS_ANDROID) && \
nit: can you change "#if defined(OS_POSIX) && !defined(OS_MACOSX) &&
!defined(OS_ANDROID)" to "#if defined(OS_LINUX)" here and below?

https://codereview.chromium.org/26541007/diff/3001/ui/gfx/gfx.gyp
File ui/gfx/gfx.gyp (right):

https://codereview.chromium.org/26541007/diff/3001/ui/gfx/gfx.gyp#newcode308
ui/gfx/gfx.gyp:308: ['exclude', '^pango_util\\.'],
nit: would it make sense to add "_util" to your list of pango file postfixes in
filename_rules.gypi and remove this?

https://codereview.chromium.org/26541007/diff/3001/ui/gfx/render_text_ozone.cc
File ui/gfx/render_text_ozone.cc (right):

https://codereview.chromium.org/26541007/diff/3001/ui/gfx/render_text_ozone.c...
ui/gfx/render_text_ozone.cc:10: PlatformFont* PlatformFont::CreateDefault() {
Shouldn't these live in platform_font_ozone.cc, not render_text_ozone.cc?

https://codereview.chromium.org/26541007/diff/3001/ui/gfx/render_text_pango.h
File ui/gfx/render_text_pango.h (right):

https://codereview.chromium.org/26541007/diff/3001/ui/gfx/render_text_pango.h...
ui/gfx/render_text_pango.h:16: class RenderTextLinux : public RenderText {
Do you plan to rename this class accordingly in a followup CL, or have you filed
an issue for myself or someone else to do that?

[sadrul, 2013-11-05 02:42:26]

https://codereview.chromium.org/26541007/diff/3001/content/browser/renderer_h...
File content/browser/renderer_host/pepper/pepper_truetype_font_list_pango.cc
(right):

https://codereview.chromium.org/26541007/diff/3001/content/browser/renderer_h...
content/browser/renderer_host/pepper/pepper_truetype_font_list_pango.cc:56:
fonts_in_family->push_back(desc);
On 2013/11/04 23:03:29, rjkroege wrote:
> there is no diff shown in this file and yet it's included? maybe you need to
> rebase? or the software is confused?

It's a file-rename (from _linux to _pango). rietveld processes it like this.

https://codereview.chromium.org/26541007/diff/3001/content/common/font_list.cc
File content/common/font_list.cc (right):

https://codereview.chromium.org/26541007/diff/3001/content/common/font_list.c...
content/common/font_list.cc:9: 
On 2013/11/04 23:03:29, rjkroege wrote:
> nit: unnecessary?

Removed.

https://codereview.chromium.org/26541007/diff/3001/ui/gfx/font_unittest.cc
File ui/gfx/font_unittest.cc (right):

https://codereview.chromium.org/26541007/diff/3001/ui/gfx/font_unittest.cc#ne...
ui/gfx/font_unittest.cc:11: #if defined(OS_POSIX) && !defined(OS_MACOSX) &&
!defined(OS_ANDROID) && \
On 2013/11/04 23:10:46, msw wrote:
> nit: can you change "#if defined(OS_POSIX) && !defined(OS_MACOSX) &&
> !defined(OS_ANDROID)" to "#if defined(OS_LINUX)" here and below?

Done.

https://codereview.chromium.org/26541007/diff/3001/ui/gfx/gfx.gyp
File ui/gfx/gfx.gyp (right):

https://codereview.chromium.org/26541007/diff/3001/ui/gfx/gfx.gyp#newcode308
ui/gfx/gfx.gyp:308: ['exclude', '^pango_util\\.'],
On 2013/11/04 23:10:46, msw wrote:
> nit: would it make sense to add "_util" to your list of pango file postfixes
in
> filename_rules.gypi and remove this?

Done.

https://codereview.chromium.org/26541007/diff/3001/ui/gfx/render_text_ozone.cc
File ui/gfx/render_text_ozone.cc (right):

https://codereview.chromium.org/26541007/diff/3001/ui/gfx/render_text_ozone.c...
ui/gfx/render_text_ozone.cc:10: PlatformFont* PlatformFont::CreateDefault() {
On 2013/11/04 23:10:46, msw wrote:
> Shouldn't these live in platform_font_ozone.cc, not render_text_ozone.cc?

Done.

https://codereview.chromium.org/26541007/diff/3001/ui/gfx/render_text_pango.h
File ui/gfx/render_text_pango.h (right):

https://codereview.chromium.org/26541007/diff/3001/ui/gfx/render_text_pango.h...
ui/gfx/render_text_pango.h:16: class RenderTextLinux : public RenderText {
On 2013/11/04 23:10:46, msw wrote:
> Do you plan to rename this class accordingly in a followup CL, or have you
filed
> an issue for myself or someone else to do that?

Made this fix here.

[msw, 2013-11-05 04:40:06]

LGTM; thanks!

[sadrul, 2013-11-05 20:14:44]

jam@ dmichael@: ping

[jam, 2013-11-06 00:18:19]

lgtm

[sadrul, 2013-11-06 06:02:51]

Committed patchset #4 manually as r233228 (presubmit successful).

[dmichael (off chromium), 2013-11-06 17:57:11]

(sorry for missing this before, pepper stuff lgtm)