third_party/WebKit/Source/web/WebPluginContainerImpl.cpp - Issue 2654083006: Revert of Sync requestFullscreen() and exitFullscreen() algorithms with the spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

Issue 2654083006: Revert of Sync requestFullscreen() and exitFullscreen() algorithms with the spec (Closed)

Patch Set: add failing test expectations Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

index f30d629d300f88ce4147923ef6bf401a71e1a127..4301e301358579e03df0c6dd2ba64b8d4aba52cf 100644

--- a/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

+++ b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

@@ -311,7 +311,7 @@ void WebPluginContainerImpl::requestFullscreen() {

}

bool WebPluginContainerImpl::isFullscreenElement() const {

- return Fullscreen::isFullscreenElement(*m_element);

+ return Fullscreen::isCurrentFullScreenElement(*m_element);

}

void WebPluginContainerImpl::cancelFullscreen() {