PRESUBMIT.py - Issue 2654073002: base: Introduce SharedMemoryTracker for POSIX (but not macOS)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 2654073002: base: Introduce SharedMemoryTracker for POSIX (but not macOS) (Closed)

Patch Set: Address on Dana's review Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index e56d4b37a95f927ef85965fe11363ceb3c3dedcc..96f8de21e9049fa7d140379bcc9a7a8cc8383df6 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -185,6 +185,7 @@ _BANNED_CPP_FUNCTIONS = (

True,

(

+ r"^base[\\\/]memory[\\\/]shared_memory_posix\.cc$",

r"^base[\\\/]process[\\\/]process_linux\.cc$",

r"^base[\\\/]process[\\\/]process_metrics_linux\.cc$",

r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]boot_times_recorder\.cc$",

« no previous file with comments | « no previous file | base/BUILD.gn » ('j') | no next file with comments »