Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 # HOW TO WRITE CONDITIONALS IN THIS FILE | 5 # HOW TO WRITE CONDITIONALS IN THIS FILE |
| 6 # ====================================== | 6 # ====================================== |
| 7 # | 7 # |
| 8 # In many other places, one would write a conditional that expresses all the | 8 # In many other places, one would write a conditional that expresses all the |
| 9 # cases when a source file is used or unused, and then either add or subtract | 9 # cases when a source file is used or unused, and then either add or subtract |
| 10 # it from the sources list in that case | 10 # it from the sources list in that case |
| (...skipping 501 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 512 "memory/ref_counted.h", | 512 "memory/ref_counted.h", |
| 513 "memory/ref_counted_delete_on_sequence.h", | 513 "memory/ref_counted_delete_on_sequence.h", |
| 514 "memory/ref_counted_memory.cc", | 514 "memory/ref_counted_memory.cc", |
| 515 "memory/ref_counted_memory.h", | 515 "memory/ref_counted_memory.h", |
| 516 "memory/scoped_policy.h", | 516 "memory/scoped_policy.h", |
| 517 "memory/scoped_vector.h", | 517 "memory/scoped_vector.h", |
| 518 "memory/shared_memory.h", | 518 "memory/shared_memory.h", |
| 519 "memory/shared_memory_android.cc", | 519 "memory/shared_memory_android.cc", |
| 520 "memory/shared_memory_handle.h", | 520 "memory/shared_memory_handle.h", |
| 521 "memory/shared_memory_handle_mac.cc", | 521 "memory/shared_memory_handle_mac.cc", |
| 522 "memory/shared_memory_handle_posix.cc", | |
| 522 "memory/shared_memory_handle_win.cc", | 523 "memory/shared_memory_handle_win.cc", |
| 523 "memory/shared_memory_helper.cc", | 524 "memory/shared_memory_helper.cc", |
| 524 "memory/shared_memory_helper.h", | 525 "memory/shared_memory_helper.h", |
| 525 "memory/shared_memory_mac.cc", | 526 "memory/shared_memory_mac.cc", |
| 526 "memory/shared_memory_nacl.cc", | 527 "memory/shared_memory_nacl.cc", |
| 527 "memory/shared_memory_posix.cc", | 528 "memory/shared_memory_posix.cc", |
| 529 "memory/shared_memory_tracker.cc", | |
| 530 "memory/shared_memory_tracker.h", | |
| 528 "memory/shared_memory_win.cc", | 531 "memory/shared_memory_win.cc", |
| 529 "memory/singleton.cc", | 532 "memory/singleton.cc", |
| 530 "memory/singleton.h", | 533 "memory/singleton.h", |
| 531 "memory/weak_ptr.cc", | 534 "memory/weak_ptr.cc", |
| 532 "memory/weak_ptr.h", | 535 "memory/weak_ptr.h", |
| 533 "message_loop/incoming_task_queue.cc", | 536 "message_loop/incoming_task_queue.cc", |
| 534 "message_loop/incoming_task_queue.h", | 537 "message_loop/incoming_task_queue.h", |
| 535 "message_loop/message_loop.cc", | 538 "message_loop/message_loop.cc", |
| 536 "message_loop/message_loop.h", | 539 "message_loop/message_loop.h", |
| 537 "message_loop/message_loop_task_runner.cc", | 540 "message_loop/message_loop_task_runner.cc", |
| (...skipping 855 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1393 "bsm", | 1396 "bsm", |
| 1394 "CoreFoundation.framework", | 1397 "CoreFoundation.framework", |
| 1395 "IOKit.framework", | 1398 "IOKit.framework", |
| 1396 "Security.framework", | 1399 "Security.framework", |
| 1397 ] | 1400 ] |
| 1398 } | 1401 } |
| 1399 | 1402 |
| 1400 # Mac or iOS. | 1403 # Mac or iOS. |
| 1401 if (is_mac || is_ios) { | 1404 if (is_mac || is_ios) { |
| 1402 sources -= [ | 1405 sources -= [ |
| 1406 "memory/shared_memory_handle_posix.cc", | |
| 1403 "memory/shared_memory_posix.cc", | 1407 "memory/shared_memory_posix.cc", |
| 1404 "native_library_posix.cc", | 1408 "native_library_posix.cc", |
| 1405 "strings/sys_string_conversions_posix.cc", | 1409 "strings/sys_string_conversions_posix.cc", |
| 1406 "threading/platform_thread_internal_posix.cc", | 1410 "threading/platform_thread_internal_posix.cc", |
| 1407 ] | 1411 ] |
| 1408 } else { | 1412 } else { |
| 1409 # Non-Mac/ios. | 1413 # Non-Mac/ios. |
| 1410 sources -= [ | 1414 sources -= [ |
| 1411 "files/file_path_watcher_fsevents.cc", | 1415 "files/file_path_watcher_fsevents.cc", |
| 1412 "files/file_path_watcher_fsevents.h", | 1416 "files/file_path_watcher_fsevents.h", |
| (...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1510 "mac/scoped_mach_port.h", | 1514 "mac/scoped_mach_port.h", |
| 1511 "mac/scoped_mach_vm.cc", | 1515 "mac/scoped_mach_vm.cc", |
| 1512 "mac/scoped_mach_vm.h", | 1516 "mac/scoped_mach_vm.h", |
| 1513 "mac/scoped_nsautorelease_pool.h", | 1517 "mac/scoped_nsautorelease_pool.h", |
| 1514 "mac/scoped_nsautorelease_pool.mm", | 1518 "mac/scoped_nsautorelease_pool.mm", |
| 1515 "mac/scoped_nsobject.h", | 1519 "mac/scoped_nsobject.h", |
| 1516 "mac/scoped_nsobject.mm", | 1520 "mac/scoped_nsobject.mm", |
| 1517 "mac/scoped_objc_class_swizzler.h", | 1521 "mac/scoped_objc_class_swizzler.h", |
| 1518 "mac/scoped_objc_class_swizzler.mm", | 1522 "mac/scoped_objc_class_swizzler.mm", |
| 1519 "mac/scoped_typeref.h", | 1523 "mac/scoped_typeref.h", |
| 1524 "memory/shared_memory_handle_posix.cc", | |
| 1520 "memory/shared_memory_posix.cc", | 1525 "memory/shared_memory_posix.cc", |
| 1521 "message_loop/message_pump_mac.h", | 1526 "message_loop/message_pump_mac.h", |
| 1522 "message_loop/message_pump_mac.mm", | 1527 "message_loop/message_pump_mac.mm", |
| 1523 "power_monitor/power_monitor_device_source_ios.mm", | 1528 "power_monitor/power_monitor_device_source_ios.mm", |
| 1524 "process/memory_stubs.cc", | 1529 "process/memory_stubs.cc", |
| 1525 "strings/sys_string_conversions_mac.mm", | 1530 "strings/sys_string_conversions_mac.mm", |
| 1526 "threading/platform_thread_mac.mm", | 1531 "threading/platform_thread_mac.mm", |
| 1527 "time/time_mac.cc", | 1532 "time/time_mac.cc", |
| 1528 ] | 1533 ] |
| 1529 | 1534 |
| 1530 set_sources_assignment_filter(sources_assignment_filter) | 1535 set_sources_assignment_filter(sources_assignment_filter) |
| 1531 } | 1536 } |
| 1532 | 1537 |
| 1533 if (is_posix && !is_mac && !is_ios && !is_android && !is_chromeos) { | 1538 if (is_posix && !is_mac && !is_ios && !is_android && !is_chromeos) { |
| 1534 sources += [ "power_monitor/power_monitor_device_source_posix.cc" ] | 1539 sources += [ "power_monitor/power_monitor_device_source_posix.cc" ] |
| 1535 } | 1540 } |
| 1536 | 1541 |
| 1542 if (!(is_posix && !is_mac)) { | |
|
danakj
2017/01/25 16:58:12
can you write this without double negatives?
also
hajimehoshi
2017/01/26 10:56:00
Done.
| |
| 1543 sources -= [ | |
| 1544 "memory/shared_memory_tracker.cc", | |
| 1545 "memory/shared_memory_tracker.h", | |
| 1546 ] | |
| 1547 } | |
| 1548 | |
| 1537 if (!use_glib) { | 1549 if (!use_glib) { |
| 1538 sources -= [ | 1550 sources -= [ |
| 1539 "message_loop/message_pump_glib.cc", | 1551 "message_loop/message_pump_glib.cc", |
| 1540 "message_loop/message_pump_glib.h", | 1552 "message_loop/message_pump_glib.h", |
| 1541 ] | 1553 ] |
| 1542 } | 1554 } |
| 1543 | 1555 |
| 1544 if (using_sanitizer) { | 1556 if (using_sanitizer) { |
| 1545 data += [ "//tools/valgrind/asan/" ] | 1557 data += [ "//tools/valgrind/asan/" ] |
| 1546 if (is_win) { | 1558 if (is_win) { |
| (...skipping 1040 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 2587 } | 2599 } |
| 2588 | 2600 |
| 2589 fuzzer_test("base_json_correctness_fuzzer") { | 2601 fuzzer_test("base_json_correctness_fuzzer") { |
| 2590 sources = [ | 2602 sources = [ |
| 2591 "json/correctness_fuzzer.cc", | 2603 "json/correctness_fuzzer.cc", |
| 2592 ] | 2604 ] |
| 2593 deps = [ | 2605 deps = [ |
| 2594 ":base", | 2606 ":base", |
| 2595 ] | 2607 ] |
| 2596 } | 2608 } |
| OLD | NEW |